Improve error reporting for ZLS installs #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves (enables at all, lol?) errors reported to the user regarding problems with downloading ZLS.
|
The error messages could probably be improved. This was a quick fix as I ran into this issue organically just now trying to upgrade my installed Zig/ZLS versions. |
tristanisham
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves (enables at all, lol?) errors reported to the user regarding problems with downloading ZLS.
Currently, ZVM silently fails to install ZLS if there is a version mismatch between Zig and ZLS. For instance, the latest release of Zig is
0.12.0but the latest ZLS is0.11.0.This PR does not resolve determining if a mismatch exists, but does at least report (somewhat) useful errors to the user.