lean: Add missing arguments to rank #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module.rank
andfinrank
expect their first argument to be the ring that our module is over.The invocations here are complete nonsense, and are talking about equalities between functions on possible (highly non-canonical) ring structures on the provided module.
A proof that this is nonsense can be found in https://github.com/leanprover-community/mathlib4/blob/1a36b1f1a21015cb61e376416b2247e627c1b4ed/Mathlib/tmp.lean#L27-L28, which states:
i.e. "if you claim the mispelled-rank is any natural number, you are claiming that the ring is trivial". (Strictly speaking the
max u v
makes this theorem not apply here, but you would have to truly be desperate to come to that for help)