Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chado buddy documentation #90

Merged
merged 22 commits into from
Nov 18, 2024
Merged

Chado buddy documentation #90

merged 22 commits into from
Nov 18, 2024

Conversation

dsenalik
Copy link
Contributor

@dsenalik dsenalik commented Aug 7, 2024

This adds documentation for all of the Chado Buddies from Tripal PR tripal/tripal#1844 and tripal/tripal#1938

I included one small unrelated fix so that the docs would build cleanly, this is in commit b24bd0e

Screenshots as of Oct 21
2024-10-21_Biological_Data_Storage


2024-10-21_Chado_Buddies


2024-10-21_Buddy_Parameters


2024-10-21_Injecting_the_Buddy_Service


@dsenalik dsenalik added the TOPIC: Extending Tripal Documentation on developing custom modules, fields, themes, etc. label Aug 7, 2024
@dsenalik dsenalik linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Comments

  • To me ChadoBuddies docs should be under "Biological Data Storage" as it's specific to working with Chado and is at an API level versus a concrete deliverable level 🤷‍♀️ That said, maybe the menu layout needs a bit of a rework 🤔 See issue Restructure menu within "Extending Tripal" #94 for my thoughts on this.
  • This documentation reminds me a lot of the old API docs. I think we want to keep these sections more tutorial/theory with examples interspersed. So an example of that might be the following sections for a ChadoCvtermBuddy where each has a small bit of text explaining examples.
    • Overview/Purpose
    • Inserting cvterms
    • Retrieving existing cvterms
    • Updating existing cvterms
    • Associating cvterms
  • Note: We'll have full API docs as well as soon as I find time to figure out how to generate them in Drupal 10.

@dsenalik
Copy link
Contributor Author

I have updated the screenshots to reflect the current PR status

Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small change so that the PR matched the update you intended it to ;-p

It's looking really good! I just have a few suggestions regarding the code samples to match new Drupal standards :-)

docs/dev_guide/biodata/buddies/inject.rst Outdated Show resolved Hide resolved
docs/dev_guide/biodata/buddies/inject.rst Outdated Show resolved Hide resolved
docs/dev_guide/biodata/buddies/inject.rst Show resolved Hide resolved
Copy link
Member

@laceysanderson laceysanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great --thanks for this! ❤️

@laceysanderson laceysanderson merged commit cc8ce0f into 4.x Nov 18, 2024
@laceysanderson laceysanderson deleted the 89-chado-buddy branch November 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Tripal DBX TOPIC: Extending Tripal Documentation on developing custom modules, fields, themes, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chado Buddy Documentation
2 participants