Reuse temp variables in Row Constructor code #22003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows reusing temporary variables with the same on-stack type across fields in RowConstructorCodeGenerator. This approach is already taken in the large row codepath and can reduce the generated code size when multiple fields have the same matching type.
martint
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows reusing temporary variables with the same on-stack type across fields in RowConstructorCodeGenerator. This approach is already taken in the large row codepath and can reduce the generated code size when multiple fields have the same matching type.
Additional context and related issues
Related change in PR airlift/bytecode#18 so that this style of variable reuse can be extended to share temp variables between different code generators producing code within the same method scope.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: