Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action-surefire-report #16471

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

nineinchnick
Copy link
Member

Description

v1.6.0 uses a more efficient XML parsing library
that should handle all test reports generated in Trino.

Bind to this version specifically because v1 doesn't point to it yet because of some compatibility issues, see ScaCap/action-surefire-report#140. It's safe to use for use since we're running on ubuntu-latest VMs.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

v1.6.0 uses a more efficient XML parsing library
that should handle all test reports generated in Trino.
@cla-bot cla-bot bot added the cla-signed label Mar 9, 2023
@nineinchnick
Copy link
Member Author

Note that this PR changes an action that doesn't run in any workflow for PRs, so we don't have to wait for it to be green.

@ebyhr ebyhr merged commit e191cb9 into trinodb:master Mar 10, 2023
@github-actions github-actions bot added this to the 411 milestone Mar 10, 2023
@ebyhr
Copy link
Member

ebyhr commented Mar 10, 2023

@nineinchnick Still failing on master with a new error message. Could you confirm that?

Run scacap/[email protected]
  with:
    fail_if_no_tests: false
    commit: e191cb9c998956574c4c401f734f9596[2](https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144#step:4:2)120f[4](https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144#step:4:4)92
    github_token: ***
    report_paths: **/surefire-reports/TEST-*.xml, **/failsafe-reports/TEST-*.xml
    create_check: true
    check_name: Test Report
    fail_on_test_failures: false
    skip_publishing: false
    file_name_in_stack_trace: false
Going to parse results form **/surefire-reports/TEST-*.xml
 **/failsafe-reports/TEST-*.xml
Error: internal error: Huge input lookup

https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144

@nineinchnick nineinchnick deleted the update-annotate-action branch March 10, 2023 09:29
@nineinchnick
Copy link
Member Author

I managed to replicate this locally. The weird thing is that it fails on reports that are not the largest:

# du -mcs test-reports/test\ report\ test\ \(plugin_trino-iceberg\,*/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml 
22	test-reports/test report test (plugin_trino-iceberg, , )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
38	test-reports/test report test (plugin_trino-iceberg, additional-catalog-tests, )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
2	test-reports/test report test (plugin_trino-iceberg, cloud-tests, )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
7	test-reports/test report test (plugin_trino-iceberg, fte-tests, )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
66	total

and

# export INPUT_REPORT_PATHS=test-reports/test\ report\ test\ \(plugin_trino-iceberg*/**/TEST-TestSuite.xml 
# node dist/index.js 
Going to parse results form test-reports/test report test (plugin_trino-iceberg*/**/TEST-TestSuite.xml
::debug::followSymbolicLinks 'false'
::debug::followSymbolicLinks 'false'
::debug::implicitDescendants 'true'
::debug::matchDirectories 'true'
::debug::omitBrokenSymbolicLinks 'true'
::debug::Search path '/src/test-reports'
::debug::Parsing file /src/test-reports/test report test (plugin_trino-iceberg, , )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
::debug::Parsing file /src/test-reports/test report test (plugin_trino-iceberg, additional-catalog-tests, )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
::error::internal error: Huge input lookup%0A

but it works when executed on the largest report:

# export INPUT_REPORT_PATHS=test-reports/test\ report\ test\ \(plugin_trino-iceberg\,\ additional-catalog-tests\,\ \)/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml 
# node dist/index.js 
Going to parse results form test-reports/test report test (plugin_trino-iceberg
 additional-catalog-tests
 )/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml
::debug::followSymbolicLinks 'false'
::debug::followSymbolicLinks 'false'
::debug::implicitDescendants 'true'
::debug::matchDirectories 'true'
::debug::omitBrokenSymbolicLinks 'true'
::debug::Search path '/src/test-reports/test report test (plugin_trino-iceberg'
::debug::Search path '/src/additional-catalog-tests'
::debug::Search path '/src/)/plugin/trino-iceberg/target/surefire-reports/TEST-TestSuite.xml'
Not publishing test result due to skip_publishing=true

::set-output name=conclusion::success

@nineinchnick
Copy link
Member Author

The solution from libxmljs/libxmljs#372 works. I'll create another PR for the action, and we'll have to update again when it gets merged.

@nineinchnick
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants