-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action-surefire-report #16471
Conversation
v1.6.0 uses a more efficient XML parsing library that should handle all test reports generated in Trino.
Note that this PR changes an action that doesn't run in any workflow for PRs, so we don't have to wait for it to be green. |
@nineinchnick Still failing on master with a new error message. Could you confirm that?
https://github.com/trinodb/trino/actions/runs/4382083337/jobs/7670771144 |
I managed to replicate this locally. The weird thing is that it fails on reports that are not the largest:
and
but it works when executed on the largest report:
|
The solution from libxmljs/libxmljs#372 works. I'll create another PR for the action, and we'll have to update again when it gets merged. |
Description
v1.6.0
uses a more efficient XML parsing librarythat should handle all test reports generated in Trino.
Bind to this version specifically because
v1
doesn't point to it yet because of some compatibility issues, see ScaCap/action-surefire-report#140. It's safe to use for use since we're running onubuntu-latest
VMs.Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: