Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing of datetime to take UTC if timezone is not provided #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parsing of datetime to take UTC if timezone is not provided #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2719da
parsing of datetime to take UTC if timezone is not provided
silent-lad May 23, 2024
5153ed3
Fix test cases
silent-lad May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trino/trino.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,7 +2029,7 @@ func parseNullTime(v string) (NullTime, error) {
var t time.Time
var err error
for _, layout := range timeLayouts {
t, err = time.ParseInLocation(layout, v, time.Local)
t, err = time.ParseInLocation(layout, v, time.UTC)
silent-lad marked this conversation as resolved.
Show resolved Hide resolved
if err == nil {
return NullTime{Valid: true, Time: t}, nil
}
Expand Down
10 changes: 5 additions & 5 deletions trino/trino_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,13 +1185,13 @@ func TestTypeConversion(t *testing.T) {
DataType: "date",
RawType: "date",
ResponseUnmarshalledSample: "2017-07-10",
ExpectedGoValue: time.Date(2017, 7, 10, 0, 0, 0, 0, time.Local),
ExpectedGoValue: time.Date(2017, 7, 10, 0, 0, 0, 0, time.UTC),
},
{
DataType: "time",
RawType: "time",
ResponseUnmarshalledSample: "01:02:03.000",
ExpectedGoValue: time.Date(0, 1, 1, 1, 2, 3, 0, time.Local),
ExpectedGoValue: time.Date(0, 1, 1, 1, 2, 3, 0, time.UTC),
},
{
DataType: "time with time zone",
Expand Down Expand Up @@ -1227,7 +1227,7 @@ func TestTypeConversion(t *testing.T) {
DataType: "time",
RawType: "time",
ResponseUnmarshalledSample: "01:02:03.123456789",
ExpectedGoValue: time.Date(0, 1, 1, 1, 2, 3, 123456789, time.Local),
ExpectedGoValue: time.Date(0, 1, 1, 1, 2, 3, 123456789, time.UTC),
},
{
DataType: "time with time zone",
Expand Down Expand Up @@ -1269,7 +1269,7 @@ func TestTypeConversion(t *testing.T) {
DataType: "timestamp",
RawType: "timestamp",
ResponseUnmarshalledSample: "2017-07-10 01:02:03.000",
ExpectedGoValue: time.Date(2017, 7, 10, 1, 2, 3, 0, time.Local),
ExpectedGoValue: time.Date(2017, 7, 10, 1, 2, 3, 0, time.UTC),
},
{
DataType: "timestamp with time zone",
Expand Down Expand Up @@ -1305,7 +1305,7 @@ func TestTypeConversion(t *testing.T) {
DataType: "timestamp",
RawType: "timestamp",
ResponseUnmarshalledSample: "2017-07-10 01:02:03.123456789",
ExpectedGoValue: time.Date(2017, 7, 10, 1, 2, 3, 123456789, time.Local),
ExpectedGoValue: time.Date(2017, 7, 10, 1, 2, 3, 123456789, time.UTC),
},
{
DataType: "timestamp with time zone",
Expand Down