Add secretMounts for the coordinator and worker #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mosabua would love a review here, I know it's a feature a lot of users are waiting for (us included) |
mosabua
reviewed
Sep 21, 2023
charts/trino/Chart.yaml
Outdated
| @@ -15,7 +15,7 @@ type: application | |||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 0.12.0 | |||
| version: 0.13.0 | |||
There was a problem hiding this comment.
Remove the version update since it cause an automatic release
|
I think this all looks good. Wdyt @losipiuk |
mosabua
requested changes
Sep 21, 2023
losipiuk
reviewed
Sep 22, 2023
|
All the checks look green, not sure what linting errors are you referring to |
Looks fine now. Not sure what I saw back then. |
losipiuk
approved these changes
Sep 25, 2023
|
Please squash the commits to one. |
mosabua
approved these changes
Sep 25, 2023
|
Thanks a lot folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #79 and #46 as well, see there for additional details and discussions