Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add extraVolumes and extraVolumeMounts tpl rendering #73

Closed
wants to merge 2 commits into from

Conversation

sebastiendejou
Copy link

Give the ability to add extraVolumes and extraVolumeMounts.
Typically, on a cluster with nonRoot pods strategy (OpenShift), we have to change the dataDir, because it's owned by root (the random uid can't write inside).
It would be great to give the possibility to add an emptyDir or pvc.

@cla-bot
Copy link

cla-bot bot commented Mar 28, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@sebastiendejou sebastiendejou marked this pull request as ready for review March 28, 2023 13:26
@drish
Copy link

drish commented Apr 20, 2023

this is pretty useful for getting the JMX java agent working too.

@doublefelix7
Copy link

Is anything holding up this merge? We'd also like the capability of mounting the additional volumes.

@koh-satoh-wpg
Copy link
Member

koh-satoh-wpg commented Jan 29, 2024

Hi, I'm pretty keen to use this feature.

I guess this is blocked because the CLA hasn't been signed. (ref).
@sebastiendejou are you willing to sign the CLA to get this moving?

If not @lshmouse I saw your PR addressing the same issue. Will you perhaps reopen the PR?

If both of you are reluctant I'm happy to submit the 3rd PR 😃

@nineinchnick
Copy link
Member

Since #129 is merged, I'll close this one. Feel free to reopen after rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants