Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to service resource #54

Closed
wants to merge 4 commits into from
Closed

Conversation

fr6nco
Copy link

@fr6nco fr6nco commented Oct 4, 2022

Requested before, but never reached the main branch. The following PR adds an option to add annotations to the service object.

Version number incremented, no breaking changes present.

@cla-bot
Copy link

cla-bot bot commented Oct 4, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tomas Boros.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Pluies
Copy link

Pluies commented Nov 16, 2022

This looks good to me fwiw 👍

@hashhar This is a duplicate of #10, but I think this one is better – with is more idiomatic, and it has the default in the values file.

@fr6nco , can you sign the CLA to turn the checks here green?

@cla-bot
Copy link

cla-bot bot commented Nov 16, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tomas Boros.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@fr6nco
Copy link
Author

fr6nco commented Nov 16, 2022

CLA sent, updater readme with the annotations param

@bitsondatadev
Copy link
Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 19, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tomas Boros.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 19, 2022

The cla-bot has been summoned, and re-checked this pull request!

@fr6nco
Copy link
Author

fr6nco commented Dec 13, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Dec 13, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tomas Boros.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Dec 13, 2022

The cla-bot has been summoned, and re-checked this pull request!

@mosabua
Copy link
Member

mosabua commented May 30, 2023

Could you rebase and resolve conflicts. I can look at merging this.

@p5 p5 mentioned this pull request Feb 15, 2024
Copy link

cla-bot bot commented Mar 5, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tomas Boros.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@nineinchnick
Copy link
Member

I'll close this, since there has been no activity here for a long time, and there's another PR superseding this one. Feel free to reopen after rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants