URL handling for security.config-file on access-control.properties #195
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -80,14 +80,27 @@ data: | |||
| {{- .Values.server.coordinatorExtraConfig | nindent 4 }} | |||
| {{- end }} | |||
|
|
|||
| {{- if .Values.accessControl }}{{- if eq .Values.accessControl.type "configmap" }} | |||
| {{ if .Values.accessControl }} | |||
| {{- if and (eq .Values.accessControl.type "remote") (.Values.accessControl.url) }} | |||
There was a problem hiding this comment.
| {{- if and (eq .Values.accessControl.type "remote") (.Values.accessControl.url) }} | |
| {{- if eq .Values.accessControl.type "remote" }} | |
| {{- if not .Values.accessControl.url }} | |
| {{- fail "`.accessControl.url` is required when `.accessControl.type` is set to `remote`" }} | |
| {{- end }} |
| # refreshPeriod: "60s" | ||
| # url: "http://trino-test/config" | ||
| # jsonPointer: "/data" | ||
| # # Rules file is mounted to /etc/trino/access-control |
There was a problem hiding this comment.
| # # Rules file is mounted to /etc/trino/access-control |
| @@ -91,8 +91,9 @@ accessControl: {} | |||
| # accessControl -- [System access | |||
| # control](https://trino.io/docs/current/security/built-in-system-access-control.html) | |||
| # configuration. | |||
| # type can be either 'configmap' when using a local file or 'remote' when using a file from an http/https URL | |||
There was a problem hiding this comment.
All docs should be correct sentences, start with a capital letter.
| # type can be either 'configmap' when using a local file or 'remote' when using a file from an http/https URL | |
| # Type can be either `configmap` when using a local file, or `remote` when using a file from an URL. |
There was a problem hiding this comment.
Also, see the repository README on how to run pre-commit hooks to regenerate the Chart's README.
As mentioned here https://trino.io/docs/current/security/file-system-access-control.html#configuration, the security.config-file can either be stored locally or remotely. Thus, this PR add the possibility to use a remote HTTP(S) endpoint to read the configuration file from.