Add missing commonLabels #142
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Send CLA to [email protected] for approval |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Who can merge this. I don’t see the merge option
From: Jan Waś ***@***.***>
Sent: Tuesday, April 16, 2024 11:57 AM
To: trinodb/charts ***@***.***>
Cc: Anwar, Jawad ***@***.***>; Author ***@***.***>
Subject: Re: [trinodb/charts] Add missing commonLabels loop under trino charts/templats/serivce.yam… (PR #142)
Caution: This is an external email. Verify any links or attachments before opening.
@nineinchnick approved this pull request.
________________________________
In charts/trino/templates/service.yaml<#142 (comment)>:
@@ -7,6 +7,9 @@ metadata:
chart: {{ template "trino.chart" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
+ {{- if .Values.commonLabels }}
Can you also add them to secret.yaml?
—
Reply to this email directly, view it on GitHub<#142 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFIVOXG447CQDJOL6SN5GWDY5VC5NAVCNFSM6AAAAABFB3IV3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBUGA2TCNRVGM>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
This electronic message may contain proprietary and confidential information of Verint Systems Inc., its affiliates and/or subsidiaries. The information is intended to be for the use of the individual(s) or entity(ies) named above. If you are not the intended recipient (or authorized to receive this e-mail for the intended recipient), you may not use, copy, disclose or distribute to anyone this message or any information contained in this message. If you have received this electronic message in error, please notify us by replying to this e-mail.
|
|
@janwar73 Can you fix both commit messages: we require first line to be shorter than 80 chars to render nicely in the GH |
|
Done, thanks
From: wendigo ***@***.***>
Sent: Wednesday, April 17, 2024 11:40 AM
To: trinodb/charts ***@***.***>
Cc: Anwar, Jawad ***@***.***>; Mention ***@***.***>
Subject: Re: [trinodb/charts] Add missing commonLabels loop under trino charts/templats/serivce.yam… (PR #142)
Caution: This is an external email. Verify any links or attachments before opening.
@janwar73<https://github.com/janwar73> Can you fix both commit messages: we require first line to be shorter than 80 chars to render nicely in the GH
—
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFIVOXG4E7CT5UHKW7NJTXLY52JU7AVCNFSM6AAAAABFB3IV3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGU4DOOBRG4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
This electronic message may contain proprietary and confidential information of Verint Systems Inc., its affiliates and/or subsidiaries. The information is intended to be for the use of the individual(s) or entity(ies) named above. If you are not the intended recipient (or authorized to receive this e-mail for the intended recipient), you may not use, copy, disclose or distribute to anyone this message or any information contained in this message. If you have received this electronic message in error, please notify us by replying to this e-mail.
|
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bond-
force-pushed
the
feature/trino_service
branch
from
41022ab
to
4c54c5a
Compare
bond-
force-pushed
the
feature/trino_service
branch
from
4c54c5a
to
df060a6
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bond-
force-pushed
the
feature/trino_service
branch
from
dae44a6
to
ed2a203
Compare
bond-
force-pushed
the
feature/trino_service
branch
from
ed2a203
to
af635b9
Compare
janwar73
changed the title
|
Who merges it now |
|
Looks good. Thank you @janwar73 . We will cut a new release soon as well hopefully. |
|
Thank you all, |
|
@mosabua How may I request a new release with this fix? |
|
Just got cut .. 0.20 |
…l in version 0.19.0