Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server.ExtraConfig indentation #100

Closed
wants to merge 1 commit into from

Conversation

ulfox
Copy link

@ulfox ulfox commented Oct 3, 2023

Switch workerExtraConfig indentation to 2
Switch coordinatorExtraConfig indentation to 2

Before

config.properties: |
coordinator=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=4GB
query.max-memory-per-node=1GB
discovery.uri=http://localhost:8080
  someKey=someValue

After

config.properties: |
coordinator=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=4GB
query.max-memory-per-node=1GB
discovery.uri=http://localhost:8080
someKey=someValue

Switch workerExtraConfig indentation to 2
Switch coordinatorExtraConfig indentation to 2
@cla-bot
Copy link

cla-bot bot commented Oct 3, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@mosabua
Copy link
Member

mosabua commented Oct 11, 2023

What does that actually fix? Indent of 4 is perfectly valid as well as far as I am concerned.

@nineinchnick
Copy link
Member

@cla-bot check

Copy link

cla-bot bot commented May 18, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Christos Kotsis.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented May 18, 2024

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

This is a valid fix:

% helm template trino charts/trino --set server.coordinatorExtraConfig=aa | grep -B8 aa 

  config.properties: |
    coordinator=true
    node-scheduler.include-coordinator=false
    http-server.http.port=8080
    query.max-memory=4GB
    query.max-memory-per-node=1GB
    discovery.uri=http://localhost:8080
      aa

@nineinchnick
Copy link
Member

Fixed in 10e2060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants