Skip to content

Commit

Permalink
Support setting annotations in deployments
Browse files Browse the repository at this point in the history
  • Loading branch information
nineinchnick committed Nov 17, 2024
1 parent 0e024e7 commit aeb13a8
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions charts/trino/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
secretName: sample-secret
path: /secrets/sample.json
```
* `coordinator.annotations` - object, default: `{}`
* `coordinator.deployment.progressDeadlineSeconds` - int, default: `600`

The maximum time in seconds for a deployment to make progress before it is considered failed. The deployment controller continues to process failed deployments and a condition with a ProgressDeadlineExceeded reason is surfaced in the deployment status.
Expand Down Expand Up @@ -520,6 +521,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
secretName: sample-secret
path: /secrets/sample.json
```
* `worker.annotations` - object, default: `{}`
* `worker.deployment.progressDeadlineSeconds` - int, default: `600`

The maximum time in seconds for a deployment to make progress before it is considered failed. The deployment controller continues to process failed deployments and a condition with a ProgressDeadlineExceeded reason is surfaced in the deployment status.
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-coordinator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ metadata:
{{- if .Values.coordinator.labels }}
{{- tpl (toYaml .Values.coordinator.labels) . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.coordinator.annotations | nindent 4 }}
spec:
progressDeadlineSeconds: {{ .Values.coordinator.deployment.progressDeadlineSeconds }}
revisionHistoryLimit: {{ .Values.coordinator.deployment.revisionHistoryLimit }}
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/templates/deployment-worker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ metadata:
{{- if .Values.worker.labels }}
{{- tpl (toYaml .Values.worker.labels) . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.worker.annotations | nindent 4 }}
spec:
progressDeadlineSeconds: {{ .Values.worker.deployment.progressDeadlineSeconds }}
revisionHistoryLimit: {{ .Values.worker.deployment.revisionHistoryLimit }}
Expand Down
2 changes: 2 additions & 0 deletions charts/trino/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,7 @@ secretMounts: []
# ```

coordinator:
annotations: {}
deployment:
progressDeadlineSeconds: 600
# coordinator.deployment.progressDeadlineSeconds -- The maximum time in seconds for a deployment to make progress before it
Expand Down Expand Up @@ -622,6 +623,7 @@ coordinator:
# ```

worker:
annotations: {}
deployment:
progressDeadlineSeconds: 600
# worker.deployment.progressDeadlineSeconds -- The maximum time in seconds for a deployment to make progress before it
Expand Down
4 changes: 4 additions & 0 deletions test-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ secretMounts:
path: /etc/trino/certificates

coordinator:
annotations:
custom/name: value
deployment:
progressDeadlineSeconds: 500
revisionHistoryLimit: 5
Expand Down Expand Up @@ -83,6 +85,8 @@ coordinator:
protocol: TCP

worker:
annotations:
custom/name: value
deployment:
progressDeadlineSeconds: 500
revisionHistoryLimit: 5
Expand Down

0 comments on commit aeb13a8

Please sign in to comment.