Fix duplicating key error for peers #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +88,34 @@ describe("<BeaconPeers />", () => { | |||
| } | |||
| }); | |||
|
|
|||
| it("resolves duplicating name for different peer connections", async () => { | |||
There was a problem hiding this comment.
Imo the test is redundant. Have you seen it fail?
There was a problem hiding this comment.
Yes, with the previous key `key={peerInfo.name}``
I can remove the test if you think we don't need it
asiia-trilitech
force-pushed
the
fix-duplicating-key-error-for-peers
branch
from
ced9c34 to
388f697
Compare
Coverage report
Test suite run success1182 tests passing in 162 suites. Report generated by 🧪jest coverage report action from 428df22 |
serjonya-trili
approved these changes
Mar 13, 2024
asiia-trilitech
force-pushed
the
fix-duplicating-key-error-for-peers
branch
from
388f697 to
428df22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
DApp might have the same name, but different beacon instances.
E. g. on mainnet & ghostnet, or when trying to connect from different browsers.
SenderId is unique for each beacon instance of a dApp, so using it as a key solves this problem.
Types of changes
Steps to reproduce
Connect to the same dApp from different browsers. Check console for errors.
Screenshots
Checklist