Handle with token with large number #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle token with large number
There was a bug where the app didn't handle sending token with large number (1e21+)
This was due to how the
BigNumber
uses scientific notation for stringifying large number, we need to usetoFixed
method instead oftoString
method to avoid the scientific notation.Types of changes
Steps to reproduce
log in with a fake account
tz1Y8cACwiwQYwLNzzHnBvLQBendT6DUR3Rn
and try and send over 1000 of PLY token. This used to fail due to the string conversion with scientific notation.Screenshots
Large number:
I also checked with small number and that worked fine:
Screen.Recording.2023-09-29.at.16.47.50.mov
Checklist