fix: WalletConnect: operationHash and hash for tezos_send #2278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adding a backwards compatible change to result for
tezos_send
operation to become compatible with TrustWallet and WalletConnect spec at the same time.The result of
tezos_send
operation in WalletConnect should look like this according to the spec:https://docs.reown.com/advanced/multichain/rpc-reference/tezos-rpc
But the actual implementation in 3 places returns this:
A
hash
field is returned instead of theoperationHash
.The implementation returns hash in
However, Taquito test dapp follows the spec: https://taquito-test-dapp.pages.dev/
A backward compatible change is implemented to return both fields:
Later, TrustWallet will be able to make a smooth switch to become compatible with the spec.
Types of changes
Steps to reproduce
With Taquito test dapp:
With TezosProvider dapp:
Screenshots
Checklist