Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom error handling #2210

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix custom error handling #2210

merged 2 commits into from
Dec 9, 2024

Conversation

dianasavvatina
Copy link
Contributor

Proposed changes

Fixing this test which fails on main

  ● <Form /> › single transaction › shows a toast if estimation fails

    expect(jest.fn()).toHaveBeenCalledWith(...expected)

    - Expected
    + Received

      Object {
    -   "description": "Some error occurred",
    +   "description": "Something went wrong. Please try again or contact support if the issue persists.",
        "isClosable": true,
        "status": "error",
      },

    Number of calls: 1

      101 |
      102 |       expect(estimateMock).toHaveBeenCalledTimes(1);
    > 103 |       expect(mockToast).toHaveBeenCalledWith({
          |                         ^
      104 |         description: "Some error occurred",
      105 |         status: "error",
      106 |         isClosable: true,

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

Screenshots

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:12am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:12am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:12am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 11:12am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants