Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WalletConnect integration, part 6, request #2029

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

dianasavvatina
Copy link
Contributor

@dianasavvatina dianasavvatina commented Oct 23, 2024

Proposed changes

requests are supported. Tested:
- send tez
- delegate / UndelegationSignPage
- originate / call contract
- stake / unstake / finalize unstake
- increase paid storage (rejected as not supported by Umami)

Types of changes

  • Bugfix
  • New feature
  • Refactor
  • Breaking change
  • UI fix

Steps to reproduce

  1. connect dapp
  2. trigger request
  3. approve or reject it

Screenshots

  • transaction
image
  • stake
image
  • unstake
image
  • finalize unstake
image
  • undelegate
image
  • staking before delegation generates error
image
  • origination
image
  • contract call
image

Checklist

  • Tests that prove my fix is effective or that my feature works have been added
  • Documentation has been added (if appropriate)
  • Screenshots are added (if any UI changes have been made)
  • All TODOs have a corresponding task created (and the link is attached to it)

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umami-embed-iframe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:22am
umami-embed-iframe-ghostnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:22am
umami-v2-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:22am
umami-v2-web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:22am

@dianasavvatina dianasavvatina changed the title feat: Add handling for WalletConnect request feat: WalletConnect integration, part 3, request Nov 11, 2024
@dianasavvatina dianasavvatina marked this pull request as ready for review November 12, 2024 11:58
Copy link
Contributor

@OKendigelyan OKendigelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

requests are supported. Tested:
 - send tez
 - delegate / undelegate
 - originate / call contract
 - stake / unstake / finalize unstake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants