Disambiguate NFT tutorials #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicNomadic
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
I think this small patch solves the issues in a quick way.
However, it would be useful to fuse them into a single tutorial. Probably the best way would be to:
- keep the complete tutorial
- scan the simple tutorial to import things that are missing from the first one, or are better explained here, if any
- include a shortcut in the complete tutorial to use the existing contract, if possible and not too disturbing
|
Merging this for now. Made a note to look at refactoring the tutorials to merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this as a potential solution to #473.
Provides disambiguation for the 3 NFT-related tutorials. Not sure if it's better to do this or to reduce the number of tutorials. Very open to opinions. I did not mention the tznft tutorial because I'm considering removing it because tznft is no longer maintained and it's a very niche tool.
Fixes #473.