Clarify dApp landing page #287
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sorry, I don't see any difference in the preview at https://docs-staging-git-nic-comments-on-dapp-landing-page-trili-tech.vercel.app/dApps. Am I looking at the right place? |
docs/dApps.mdx
Outdated
|
|
||
| <LucidDiagram width="640px" height="480px" src="https://lucid.app/documents/embedded/8caf9ef1-11e4-454a-bbb6-ef4852515959" id=".4NXymECcQqz" /> | ||
| <LucidDiagram width="640px" height="360px" src="https://lucid.app/documents/embedded/8caf9ef1-11e4-454a-bbb6-ef4852515959" id=".4NXymECcQqz" /> |
There was a problem hiding this comment.
Referring to an artifact which is editable online separately from any github control seems a real flaw, isn't it? Why don't you just export your picture as a static image, and perhaps link in a comment to the source, in case one wants to edit it?
There was a problem hiding this comment.
Ok, I put it in as a static image. In cases of large diagrams I like offering the LucidChart container because people can scroll and zoom to explore the diagram, but yes, it means that the artifact is not in the repository.
There was a problem hiding this comment.
It's much better like this, both from usability and security viewpoints.
People can zoom in without the Lucid source, isn't it? If you mean that they would have more resolution, maybe you can try to improve that in the static image, either by increasing its resolution, or by exporting SVG (which is supposed to be more scalable, as the name implies).
Nic had some comments after #221 was merged. This PR includes them.