Mobile-tutorial #214
Mobile-tutorial #214
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Some comments from a first pass. I wasn't able to get it working but will try again.
- Please have a look through and make sure that sentences have periods or colons at the end where appropriate.
- Remove spaces before punctuation marks like colons and exclamation points.
- Lots of incomplete sentences. Let me know if you'd like me to update grammar/syntax.
- At the end of part 3 I tried to play a game by connecting and disconnecting two wallets. I got an error the says "Failed to check bytes" after both players have made a decision and I clicked Reveal. I'll try again.
- I wonder if deploying to the android store should be part of the tutorial or not -- it's not really relevant to the tutorial, but it is interesting.
- Include "a," "an," and "the" so the language doesn't sound robotic. For example, "Uninstall conflicting old jest libraries/react-scripts, install required Tezos web3 dependencies and Vite framework." Should be "Uninstall the conflicting Jest libraries and scripts and install the required Tezos dependencies and the Vite framework."
|
@timothymcmackin Is it ok with last changes here ? Do you need help on other PRs ? |
I think we can merge this now. Later I will fix the issue with spaces before punctuation marks and some other small things.
If you wanted to review any of these, it would be a big help: |
|
On second thought, I'm going to see if we can get someone from developer success to test this tutorial and make sure it goes smoothly. |
|
Thank you Adebola , I fixed all Ready to merge ? |
Yes! all good. |
mobile tutorial