crypto: verify sig should be more specific #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emturner
force-pushed
the
emturner@crypto-verify-sig-should-be
branch
2 times, most recently
from
1b850a3 to
661432c
Compare
emturner
force-pushed
the
emturner@crypto-verify-sig-should-be
branch
from
661432c to
8f5744c
Compare
vapourismo
reviewed
Jan 3, 2024
vapourismo
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we update
verify_sigimpls to require the specific signature type for the key being used.To ease use with
Signatureenum, we provideTryFrom<Signature> for <SigType>impls.Closes #52
NB this does slightly the opposite of what was requested in #52. It's addressed, however, as it is much easier now to convert too the correct signature type, to pass through.
The corresponding
PublicKeytype in the SDK, will be able to use this to greater effect, and can indeed receive the more generalSignaturetype.This layout/structure is more in-line with the
signaturemodule provided inoctez/tezos_crypto.