crypto: remove legacy base58 encoding for SecretKeyEd25519 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emturner
force-pushed
the
emturner@sked25519-b58
branch
2 times, most recently
from
f3e528f to
c64a247
Compare
|
I'm not very familiar with this code but the fix looks reasonable to me and the test seems to address issue #45. |
emturner
force-pushed
the
emturner@sked25519-b58
branch
2 times, most recently
from
71622d6 to
d43ab60
Compare
emturner
force-pushed
the
emturner@sked25519-b58
branch
from
d43ab60 to
69de87a
Compare
|
Took the diff from this MR applied it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous base58 check encoding was incorrectly using the legacy format, where the encoded key was actually the concatenation of
sk+pk.fixes #45