crypto: add explicit base58 prefix check #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, hashes could accidentally be parsed with an incorrect hash
type, provided:
- the lengths of the encoded were the same
- the lengths of the base58 prefixes were the same
This would manifest, for example, by the following succeeding:
`ContractTz1Hash::from_base58check("tz4FENGt5zkiGaHPm1ya4MgLomgkL1k7Dy7q")`
This will now return
`Err(FromBase58CheckError::IncorrectBase58Prefix)` instead.
emturner
force-pushed
the
emturner@base58-prefix-check
branch
from
e94ba98 to
169f0ae
Compare
|
LGTM, fixes the bug! |
victor-dumitrescu
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, hashes could accidentally be parsed with an incorrect hash
type, provided:
This would manifest, for example, by the following succeeding:
ContractTz1Hash::from_base58check("tz4FENGt5zkiGaHPm1ya4MgLomgkL1k7Dy7q")This will now return
Err(FromBase58CheckError::IncorrectBase58Prefix)instead.