Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable nanox generated tests #46

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

spalmer25
Copy link
Collaborator

fixes #43
The $URL/events?currentscreenonly=true service does not seem to correspond to what is actually on the screen.
Fortunately, the $URL/events service allows the recovery of everything that has been displayed, including what has been lost by $URL/events?currentscreenonly=true.

@spalmer25 spalmer25 linked an issue Oct 5, 2023 that may be closed by this pull request
@spalmer25 spalmer25 force-pushed the palmer@functori@43-nanox-re-enable-generated-tests branch from 83c5691 to b9c7e55 Compare October 5, 2023 13:33
@spalmer25 spalmer25 marked this pull request as ready for review October 5, 2023 13:34
@spalmer25 spalmer25 requested a review from emturner October 5, 2023 13:34
Copy link
Collaborator

@emturner emturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! One minor comment

tests/integration/check_section_text.py Outdated Show resolved Hide resolved
While the 'events?currentscreenonly=true' service does not work
properly for nanox in the sha-6a34680 version of speculos
@spalmer25 spalmer25 force-pushed the palmer@functori@43-nanox-re-enable-generated-tests branch from b9c7e55 to 056fac0 Compare October 6, 2023 07:26
@spalmer25 spalmer25 requested a review from emturner October 9, 2023 07:50
@emturner emturner merged commit e694e3e into main Oct 9, 2023
101 checks passed
@emturner emturner deleted the palmer@functori@43-nanox-re-enable-generated-tests branch October 9, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nanox: re-enable generated tests
2 participants