Implement blindsigning modes on stax/flex #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajinkyaraj-23
force-pushed
the
283-limit-the-number-of-screen-displayed-staxflex
branch
8 times, most recently
from
a8f4ab2 to
95fe66f
Compare
…gningStart for stax
Remove redundant code
It should show warning screens and summary pages.
ajinkyaraj-23
force-pushed
the
283-limit-the-number-of-screen-displayed-staxflex
branch
3 times, most recently
from
1b7fefd to
8bd2082
Compare
spalmer25
reviewed
Sep 23, 2024
...tegration/touch/snapshots/flex/test_blindsign_different_modes/tbdm_blindsign_on_screen_1.png
Outdated
Show resolved
Hide resolved
tests/integration/touch/snapshots/flex/test_blindsign_too_deep/signing_successful.png
Outdated
Show resolved
Hide resolved
ajinkyaraj-23
force-pushed
the
283-limit-the-number-of-screen-displayed-staxflex
branch
from
8bd2082 to
dbe858e
Compare
…of-screen-displayed-staxflex
spalmer25
reviewed
Sep 24, 2024
1.(test) add skip in review class (ragger) 2. add testing for unexpected states in blindsigning flow.
spalmer25
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.