Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blindsigning in Settings for nano. #275

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

Options are "For Large Tx", "ON", "OFF"
Update snapshots for nano

Options are "For Large Tx", "ON", "OFF"
Update snapshots for nano
@ajinkyaraj-23 ajinkyaraj-23 added the app::wallet issues relating to the wallet app label Sep 4, 2024
@ajinkyaraj-23 ajinkyaraj-23 added this to the fix-scrolling milestone Sep 4, 2024
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Sep 4, 2024
UX_STEP_CB(ux_expert_mode_step, bn, expert_mode_toggle(),
{"Expert mode", global.expert_mode_state});
static void
blindsign_toggle()

Check notice

Code scanning / CodeQL

Unused static function Note

Static function blindsign_toggle is unreachable
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the few remarks, it looks good to me.

app/src/ui_settings.c Outdated Show resolved Hide resolved
app/src/globals.h Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 268-create-a-max_signing_pages-settings branch 4 times, most recently from 9e272ee to d268080 Compare September 6, 2024 14:45
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 268-create-a-max_signing_pages-settings branch 3 times, most recently from 0b5f0f3 to 78fc539 Compare September 9, 2024 11:44
@ajinkyaraj-23 ajinkyaraj-23 merged commit 6361949 into main Sep 9, 2024
136 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app::wallet issues relating to the wallet app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants