Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nano home page according to Ledger app boilerplate #271

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Make nano home page according to Ledger app boilerplate #271

merged 2 commits into from
Sep 3, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Aug 23, 2024 •
edited
Loading

  • Change nano home and settings according to app boilerplate

@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Aug 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 linked an issue Aug 23, 2024 that may be closed by this pull request
Create a blindsigning settings #268
Closed
@ajinkyaraj-23
Copy link
Collaborator Author

UX update for stax is remaining. This PR only adds the settings. Does not use the settings. Need to create another PR where based on the settings the warnings and summary is displayed.

spalmer25

This comment was marked as duplicate.

Sign in to view

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 268-create-a-max_signing_pages-settings branch from 8227e30 to 54ef70e Compare September 2, 2024 09:05
@ajinkyaraj-23 ajinkyaraj-23 changed the title 268 create a max signing pages settings Make nano home page according to Ledger app boilerplate Sep 2, 2024
@ajinkyaraj-23 ajinkyaraj-23 removed a link to an issue Sep 2, 2024
Create a blindsigning settings #268
Closed
spalmer25
spalmer25 reviewed Sep 2, 2024
View reviewed changes
app/src/ui_home.c Outdated Show resolved Hide resolved
app/src/ui_home.c Outdated Show resolved Hide resolved
app/src/ui_home.c Outdated Show resolved Hide resolved
app/src/ui_settings.c Outdated Show resolved Hide resolved
app/src/ui_home.c Outdated Show resolved Hide resolved
tests/integration/nano/test_basic.py Show resolved Hide resolved
@spalmer25
Copy link
Collaborator

There are warnings during compilation. It would be better if there were none.

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 268-create-a-max_signing_pages-settings branch 2 times, most recently from 7a4ba44 to b9ef919 Compare September 2, 2024 16:10
@ajinkyaraj-23
Copy link
Collaborator Author

There are warnings during compilation. It would be better if there were none.

Removed warnings. Thanks

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 268-create-a-max_signing_pages-settings branch 2 times, most recently from 48f24fa to 33cc794 Compare September 2, 2024 17:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 2, 2024
View reviewed changes
app/src/ui_settings.c Dismissed Show dismissed Hide dismissed
@ajinkyaraj-23 ajinkyaraj-23 merged commit c6fd93e into main Sep 3, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajinkyaraj-23 @spalmer25