Change blindsign flow according to guideline. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/ui_stream_nbgl.c
Outdated
Comment on lines
106
to
113
| // const char *blindsign_msg = | ||
| // "Your Ledger cannot decode this transaction. If you sign it, you could be authorizing " | ||
| // "malicious actions that can drain your wallet.\n"; | ||
| // const char *learn_more_msg = '\n Learn More: tinyurl.com/ledger-Tezos'; | ||
| // char total_blindsign_msg[150]= {'\0'}; | ||
| // memcpy(total_blindsign_msg, blindsign_msg, sizeof(blindsign_msg)); | ||
| // memcpy(total_blindsign_msg + sizeof(blindsign_msg), global.error_code, sizeof(global.error_code) ); | ||
| // memcpy(total_blindsign_msg + sizeof(blindsign_msg) + sizeof(global.error_code), learn_more_msg, sizeof(learn_more_msg)); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| @@ -633,7 +633,7 @@ | |||
| if (confirm) { | |||
| nbgl_useCaseStatus("TRANSACTION\nSIGNED", true, accept_blindsign_cb); | |||
| } else { | |||
| tz_reject_ui(); | |||
| tz_reject(); | |||
Check warning
Code scanning / CodeQL
Implicit function declaration Warning
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@remove-blindsign-button
branch
3 times, most recently
from
fd00470 to
392bb9e
Compare
If blindsigning is required, show two warning screens , the 2nd being details about the error. Standardize the msgs shown in confirm trasaction/rejection screens using macros.
1. test_basic.py - remove blindsigning settings from settings menu 2. test_blindsign_too_deep.py - Remove blindsign enabled section and consolidate two warning screens in one utils function. 3. test_blindsign_too_deep_rejections.py - Address changes due to two warning screens. Note that first warning screen has reverse confirm/reject buttons 4. test_blindsign_too_large.py - Remove blindsign enabled section. 5. test_parsing_errors.py - add the blindsign warning screen. note that the warning screen has reverse confirm/reject buttons.
info.png is deleted on unrelated golden snapshot generations.
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@remove-blindsign-button
branch
from
392bb9e to
52d748e
Compare
spalmer25
reviewed
Jul 17, 2024
tests/integration/touch/snapshots/stax/test_blindsign_too_deep/tbtd_review_1.png
Outdated
Show resolved
Hide resolved
Use standard practice in constructoin of blindsign warning screen 2 msg. Update url to Tezos-ledger
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@remove-blindsign-button
branch
from
b80dc4b to
e3417ef
Compare
spalmer25
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove blindsign button from stax
Checklist
develop