Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase on ledgerhq/app-tezos-new #232

Closed
wants to merge 39 commits into from
Closed

Rebase on ledgerhq/app-tezos-new #232

wants to merge 39 commits into from

Conversation

ajinkyaraj-23
Copy link
Collaborator

fixes #231

fbeutin-ledger and others added 30 commits January 22, 2024 15:30
@fbeutin-ledger
Merge pull request #3 from trilitech/main
930b423 
`v3.0.2`
@sgliner-ledger
[auto] Update screenshot
f9eec5c
@sgliner-ledger
[auto] Update screenshot
45457c7
@ajinkyaraj-23
Change "Expert Mode Enabled" screen to match "TRANSACTION SIGNED" format
a4e5775
@spalmer25 @ajinkyaraj-23
Docker: fix ledger app-builder version to 3.14.0
fd3f1ec
@spalmer25 @ajinkyaraj-23
Style: name parameters in function prototype
101ae3b 
[misra-c2012-8.2] Function types shall be in prototype form with named parameters
@spalmer25 @ajinkyaraj-23
Style: suffix unsigned type constants with 'u'
0d8bbea 
[misra-c2012-7.2] A "u" or "U" suffix shall be applied to all integer constants that are represented in an unsigned type
@spalmer25 @ajinkyaraj-23
Style: make tz_string_to_mutez clearer
646b4ef 
[misra-c2012-13.4] The result of an assignment operator should not be used
@spalmer25 @ajinkyaraj-23
Style: avoid one-line if, while, for, ...
64ebf50 
[misra-c2012-15.6] The body of an iteration-statement or a selection-statement shall be a compound-statement
@spalmer25 @ajinkyaraj-23
Style: explicit the precedence of operators
389ee57 
[misra-c2012-12.1] The precedence of operators within expressions should be made explicit
@spalmer25 @ajinkyaraj-23
Header guard: add the missing header guard to handle_swap.h
36aef28 
to prevent it from being included twice
@ajinkyaraj-23
Remove unused Ledger flags
1af0de9 
APPLICATION_FLAG_GLOBAL_PIN, APPLICATION_FLAG_BOLOS_SETTINGS
@ajinkyaraj-23
Add new Oxford2 entrypoints
e2abf49
@ajinkyaraj-23
Remove unnecessary comments
8a498c9
@ajinkyaraj-23
Reset entire buffer not just its size
6da3923
@ajinkyaraj-23
- Initialize pressed_right to 0.
26e8721
@ajinkyaraj-23
Remove redundant global.step check
e6b4200
@ajinkyaraj-23
Fix unsigned int treated as int.
9a4ca9f
@spalmer25 @ajinkyaraj-23
Parser: reduce TZ_FIELD_NAME_SIZE size to a more appropriate size
9b12e71
@spalmer25 @ajinkyaraj-23
Makefile: build the app with the latest app-builder version
904f73d
@spalmer25 @ajinkyaraj-23
Bump up the ledger-sdk in CI
e03d17e 
Co-authored-by: Ajinkya Rajandekar <[email protected]>
@spalmer25 @ajinkyaraj-23
CodeQL: make strlcpy explicit
79728a7
@spalmer25 @ajinkyaraj-23
CodeQL: make all the enumeration items explicit
16df304 
if items other than the first are defined
@spalmer25 @ajinkyaraj-23
CodeQL: short tz_step_read_num switch case
e26d259
@spalmer25 @ajinkyaraj-23
Documentation: add documentation for formatting.(c|h)
8f0e585
@spalmer25 @ajinkyaraj-23
Documentation: add documentation for parser_state.(c|h)
c372074
@spalmer25 @ajinkyaraj-23
Documentation: add documentation for number parser
0281844
@spalmer25 @ajinkyaraj-23
Documentation: add documentation for micheline parser
dc79169
@spalmer25 @ajinkyaraj-23
Documentation: add documentation for operations parser
ea7fb72
@spalmer25 @ajinkyaraj-23
Parser: add the riscv SORU_KIND
8c4a42b
@ajinkyaraj-23 ajinkyaraj-23 added the app::wallet issues relating to the wallet app label Mar 15, 2024
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Mar 15, 2024
@ajinkyaraj-23 ajinkyaraj-23 linked an issue Mar 15, 2024 that may be closed by this pull request
Rebase on LedgerHq/app-tezos-new #231
Closed
@emturner
Copy link
Collaborator

hey! not sure you should be rebasing to get these changes in? just a back merge from their fork should do

@ajinkyaraj-23
Copy link
Collaborator Author

CLosing as merging is preferred over rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
app::wallet issues relating to the wallet app
Projects
None yet
Milestone
Wallet: v3.0.3 - security audit
Development

Successfully merging this pull request may close these issues.

Rebase on LedgerHq/app-tezos-new
5 participants
@ajinkyaraj-23 @emturner @fbeutin-ledger @sgliner-ledger @spalmer25