Skip to content

Commit

Permalink
Merge pull request #16 from trilitech/elric1@upstream-guidelines
Browse files Browse the repository at this point in the history
Add the guidelines github workflow from app-boilerplate
  • Loading branch information
elric1 authored Sep 29, 2023
2 parents 83a37b1 + 2ed1c20 commit 5505f36
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 4 deletions.
25 changes: 25 additions & 0 deletions .github/workflows/guidelines_enforcer.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Ensure compliance with Ledger guidelines

# This workflow is mandatory in all applications
# It calls a reusable workflow guidelines_enforcer developed by Ledger's internal developer team.
# The successful completion of the reusable workflow is a mandatory step for an app to be available on the Ledger
# application store.
#
# More information on the guidelines can be found in the repository:
# LedgerHQ/ledger-app-workflows/

on:
workflow_dispatch:
push:
branches:
- master
- main
- develop
pull_request:

jobs:
guidelines_enforcer:
name: Call Ledger guidelines_enforcer
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_guidelines_enforcer.yml@v1
with:
relative_app_directory: app
10 changes: 6 additions & 4 deletions app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ PATH_APP_LOAD_PARAMS = "44'/1729'"
# * It must at least contains one value.
# * Values can be the app ticker or anything else but should be unique.
VARIANT_PARAM = APP_TYPE
VARIANT_VALUES = WALLET
VARIANT_VALUES = tezos_wallet

# Enabling DEBUG flag will enable PRINTF and disable optimizations
#DEBUG = 1
Expand Down Expand Up @@ -135,9 +135,11 @@ CFLAGS += -Wwrite-strings
########################################
# See SDK `include/appflags.h` for the purpose of each permission
#HAVE_APPLICATION_FLAG_DERIVE_MASTER = 1
#HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1
#HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1
#HAVE_APPLICATION_FLAG_LIBRARY = 1
ifneq ($(TARGET_NAME), TARGET_NANOS)
HAVE_APPLICATION_FLAG_GLOBAL_PIN = 1
HAVE_APPLICATION_FLAG_BOLOS_SETTINGS = 1
endif
HAVE_APPLICATION_FLAG_LIBRARY = 1

########################################
# Application communication interfaces #
Expand Down

0 comments on commit 5505f36

Please sign in to comment.