Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: reduce updating time for home screens #92

Merged

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Apr 3, 2024

Context

After a few tests on the weekly test network, we discovered that the signing process was not fast enough.

A comparison of the signing speed was carried out, and commit Remove custom screensaver. Users can enable custom screensaver from Ledger settings clearly had an impact on the signing time:

all-times

Among other things, it adds an update to the home screens after each signature, which slows down signature time.

Suggestion

  • no longer update all the data needed to display the home screens, but only those that are likely to have changed.
  • stop updating the HWM screen at the time of signing
  • update the HWM screen on both click

Results

all-times-fixed

@spalmer25 spalmer25 added this to the Baking app upgrade milestone Apr 3, 2024
@spalmer25 spalmer25 self-assigned this Apr 3, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@reduce-updating-time-for-home-screens branch from 471b033 to ea70928 Compare April 3, 2024 15:32
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 April 4, 2024 07:47
@spalmer25 spalmer25 marked this pull request as ready for review April 4, 2024 07:47
@spalmer25 spalmer25 force-pushed the palmer@functori@reduce-updating-time-for-home-screens branch from ea70928 to 5c53f34 Compare April 4, 2024 09:36
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a description in Readme that to see latest HWM on nano devices , press both buttons.
Add a seperate heading called "how the app works " or something like that. Then add a single section about HWM for now. We can expand that later in another issue.

@ajinkyaraj-23
Copy link
Collaborator

Also, did you test the latest signing time after these updates?

@spalmer25
Copy link
Collaborator Author

spalmer25 commented Apr 4, 2024

Also, did you test the latest signing time after these updates?

Yes, you can see the result for ED25519 of the 3 last commit in the Results part of this PR:

Time elapsed for derivation type : ED25519_tz1dyX3B1CFYa2DfdFLyPtiJCfQRUgPVME6E is : 78.30447840690613

Time elapsed for derivation type : SECP256K1_tz2GB5YHqF4UzQ8GP5yUqdhY9oVWRXCY2hPU is : 58.6905243396759

Time elapsed for derivation type : SECP256R1_tz3UMNyvQeMj6mQSftW2aV2XaWd3afTAM1d5 is : 58.6864333152771

Time elapsed for derivation type : BIP32_ED25519_tz1VKyZ3RFDwTkrz5LKcTc6fcYqZj6pvsyA7 is : 144.5561113357544

@spalmer25 spalmer25 force-pushed the palmer@functori@reduce-updating-time-for-home-screens branch from 5c53f34 to b3c3e8c Compare April 5, 2024 08:27
So the HWM will not be dynamically update
Update only screen potentially changed
@spalmer25 spalmer25 force-pushed the palmer@functori@reduce-updating-time-for-home-screens branch from b3c3e8c to 9316583 Compare April 5, 2024 13:42
To allow user to update the HWM screen
@spalmer25 spalmer25 force-pushed the palmer@functori@reduce-updating-time-for-home-screens branch from 9316583 to a3f7090 Compare April 5, 2024 13:52
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 April 5, 2024 13:53
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 1c7a674 into main Apr 5, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants