-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: reduce updating time for home screens #92
UI: reduce updating time for home screens #92
Conversation
471b033
to
ea70928
Compare
ea70928
to
5c53f34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add a description in Readme that to see latest HWM on nano devices , press both buttons.
Add a seperate heading called "how the app works " or something like that. Then add a single section about HWM for now. We can expand that later in another issue.
Also, did you test the latest signing time after these updates? |
Yes, you can see the result for
|
5c53f34
to
b3c3e8c
Compare
So the HWM will not be dynamically update
Update only screen potentially changed
b3c3e8c
to
9316583
Compare
To allow user to update the HWM screen
9316583
to
a3f7090
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
After a few tests on the weekly test network, we discovered that the signing process was not fast enough.
A comparison of the signing speed was carried out, and commit Remove custom screensaver. Users can enable custom screensaver from Ledger settings clearly had an impact on the signing time:
Among other things, it adds an update to the home screens after each signature, which slows down signature time.
Suggestion
Results