Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HWM settings in Ledger #91

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add HWM settings in Ledger #91

merged 2 commits into from
Apr 8, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Mar 28, 2024 •
edited
Loading

  • Add HWM to N_data persistent storage
  • Add HWM to settings in nano home layout
  • Add HWM switch to stax settings page
  • Remove migrated_to_tenderbake

@ajinkyaraj-23 ajinkyaraj-23 linked an issue Mar 28, 2024 that may be closed by this pull request
Add HWM on/off in settings #90
Closed
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch from 60d5229 to 70f2729 Compare March 28, 2024 10:30
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Mar 28, 2024
@ajinkyaraj-23 ajinkyaraj-23 requested a review from spalmer25 March 28, 2024 10:30
@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone Mar 28, 2024
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch 3 times, most recently from ef8946e to 5a35ce4 Compare March 28, 2024 11:01
spalmer25
spalmer25 reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hwm settings does not have any impact on the app, is that on purpose?

...ots/stax/test_review_home/BIP32_ED25519_tz1VKyZ3RFDwTkrz5LKcTc6fcYqZj6pvsyA7/app_context.png Outdated Show resolved Hide resolved
...ots/stax/test_review_home/BIP32_ED25519_tz1VKyZ3RFDwTkrz5LKcTc6fcYqZj6pvsyA7/description.png Outdated Show resolved Hide resolved
test/test_instructions.py Show resolved Hide resolved
src/ui_bagl.c Outdated Show resolved Hide resolved
src/ui_nbgl.c Outdated Show resolved Hide resolved
@ajinkyaraj-23
Copy link
Collaborator Author

The hwm settings does not have any impact on the app, is that on purpose?

The app behaviour changes are in progress. I just got the display and button changes done.

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch 6 times, most recently from e25ea20 to 964fc41 Compare April 2, 2024 15:31
spalmer25
spalmer25 reviewed Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we've finally got rid of the dependency on what came before tenderbake

src/to_string.h Outdated Show resolved Hide resolved
src/ui_bagl.c Show resolved Hide resolved
src/ui_bagl.c Outdated Show resolved Hide resolved
src/ui_bagl.c Outdated Show resolved Hide resolved
test/utils/navigator.py Outdated Show resolved Hide resolved
src/ui_nbgl.c Outdated Show resolved Hide resolved
test/test_instructions.py Outdated Show resolved Hide resolved
test/utils/client.py Outdated Show resolved Hide resolved
test/utils/navigator.py Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch 3 times, most recently from aab6b79 to a7b004d Compare April 5, 2024 14:00
@spalmer25 spalmer25 self-requested a review April 5, 2024 14:01
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch from a7b004d to bdd89f7 Compare April 5, 2024 14:03
spalmer25
spalmer25 reviewed Apr 5, 2024
View reviewed changes
src/ui_bagl.c Outdated Show resolved Hide resolved
test/utils/client.py Outdated Show resolved Hide resolved
@ajinkyaraj-23
Add a settings page with facility to turn HWM on/off
d846193 
- Add HWM to N_data persistent storage
- Add HWM to settings in nano home layout
- Add HWM switch to stax settings page
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch from bdd89f7 to b169879 Compare April 5, 2024 14:52
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 90-add-hwm-onoff-in-settings branch from b169879 to dcfe2b7 Compare April 5, 2024 15:43
@spalmer25 spalmer25 self-requested a review April 8, 2024 06:37
spalmer25
spalmer25 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmer25 spalmer25 merged commit 33ef9d2 into main Apr 8, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.

Add HWM on/off in settings
2 participants
@ajinkyaraj-23 @spalmer25