Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit config file #9

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .clang-format

This file was deleted.

1 change: 0 additions & 1 deletion .github/workflows/build_and_functional_tests_baking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,3 @@ jobs:
with:
download_app_binaries_artifact: "compiled_app_binaries"
test_dir: test/python

4 changes: 2 additions & 2 deletions .github/workflows/lint-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
uses: actions/checkout@v2

- name: Lint
uses: DoozyX/clang-format-lint-action@v0.11
uses: DoozyX/clang-format-lint-action@v0.17
with:
source: "./"
extensions: "h,c"
clangFormatVersion: 10
clangFormatVersion: 17
21 changes: 21 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# To install hooks, run:
# pre-commit install --hook-type pre-commit
# pre-commit install --hook-type commit-msg

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.3.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- repo: local
hooks:
- id: clang-format
name: clang-format
description: Run `clang-format` on C/C++/CUDA files.
entry: clang-format -i
language: system
files: ^
types: [file, c]
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
"string": "c"
},
"editor.formatOnSave": true
}
}
1 change: 0 additions & 1 deletion APDUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,3 @@ There are some limitations for Michelson parsing that should be noted.
- “contract-to-contract” requires that you use:
- the default endpoint for your destination contract
- the parameters must be of type unit

3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ Originated accounts have names beginning with `KT1` rather than `tz1`, `tz2` or

### Signing Michelson
The wallet app allows you to sign packed Michelson values. This can be useful when interacting with a Michelson contract that
uses `PACK` and `CHECK_SIGNATURE` (multisig contracts use this functionality).
uses `PACK` and `CHECK_SIGNATURE` (multisig contracts use this functionality).

Here is an example:
```
Expand Down Expand Up @@ -1054,4 +1054,3 @@ If you install a Ledger application, such as Tezos Wallet or Tezos Baking, outsi
You can email us at [email protected] and request to join our Slack.
We have several channels about baking and one specifically for our Ledger applications.
You can ask questions and get answers from Obsidian staff or from the community.

26 changes: 13 additions & 13 deletions Release-1.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,23 +126,23 @@ manually. Most users will never need to use this feature.

### U2F Support

The Wallet Application now supports U2F protocol, the standard method for enabling
browser access by 3rd party wallet providers for all tokens. Recent versions
of Ledger Nano S firmware (v1.4.1+) allow us to support browsers seamlessly without the need
to toggle it in settings; the app will automatically detect which protocol is
The Wallet Application now supports U2F protocol, the standard method for enabling
browser access by 3rd party wallet providers for all tokens. Recent versions
of Ledger Nano S firmware (v1.4.1+) allow us to support browsers seamlessly without the need
to toggle it in settings; the app will automatically detect which protocol is
being used.

#### APDU level error: Unexpected sequence number (expect 0, got 191)

As a side effect of adding U2F support, users will see this error when sending operations
As a side effect of adding U2F support, users will see this error when sending operations
to the Wallet Application. There are two situations where this error will fire:

* If you send an operation to the Tezos Wallet Application. `tezos-client` might interpret
the presence of U2F support as a sequence number error, but it will recover from this error
and successfully be able to communicate with the device over APDU protocol. In our experience,
* If you send an operation to the Tezos Wallet Application. `tezos-client` might interpret
the presence of U2F support as a sequence number error, but it will recover from this error
and successfully be able to communicate with the device over APDU protocol. In our experience,
the operation always succeeds despite this error. We intend to have the error message from `tezos-client`
adjusted to reflect the success of these operations.
* If you send an operation to the Ledger device and neither Tezos Application is open.
* If you send an operation to the Ledger device and neither Tezos Application is open.
You'll be communicating with the ledger OS, not one of the Tezos Applications.

## Baking Application -- Release Details
Expand All @@ -161,10 +161,10 @@ level, only one endorsement will actually need to be signed, and you
will receive the reward for all the endorsement slots at that level.

As before, you may reset the high watermark with a reset command
(`tezos-client set ledger high watermark for <uri> to <high watermark>`), which
will prompt "Reset HWM" and the new value. Legitimate reasons to change the high
watermark include switching to a test network at a different block level or
restoring a baker after an attacker or software error caused a block to be signed
(`tezos-client set ledger high watermark for <uri> to <high watermark>`), which
will prompt "Reset HWM" and the new value. Legitimate reasons to change the high
watermark include switching to a test network at a different block level or
restoring a baker after an attacker or software error caused a block to be signed
with too high a level.

## Acknowledgements
Expand Down
2 changes: 1 addition & 1 deletion nix/dep/flextesa-dev/default.nix
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# DO NOT HAND-EDIT THIS FILE
import (import ./thunk.nix)
import (import ./thunk.nix)
2 changes: 1 addition & 1 deletion nix/dep/flextesa-dev/thunk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ let fetch = {url, rev, branch ? null, sha256 ? null, fetchSubmodules ? false, pr
url = realUrl; inherit rev sha256;
};
json = builtins.fromJSON (builtins.readFile ./git.json);
in fetch json
in fetch json
2 changes: 1 addition & 1 deletion nix/dep/nanos-secure-sdk/default.nix
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# DO NOT HAND-EDIT THIS FILE
import (import ./thunk.nix)
import (import ./thunk.nix)
2 changes: 1 addition & 1 deletion nix/dep/nanos-secure-sdk/thunk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ let fetch = { private ? false, fetchSubmodules ? false, owner, repo, rev, sha256
inherit owner repo rev sha256 fetchSubmodules private;
};
json = builtins.fromJSON (builtins.readFile ./github.json);
in fetch json
in fetch json
2 changes: 1 addition & 1 deletion nix/dep/nixpkgs/default.nix
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# DO NOT HAND-EDIT THIS FILE
import (import ./thunk.nix)
import (import ./thunk.nix)
2 changes: 1 addition & 1 deletion nix/dep/nixpkgs/thunk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ let fetch = { private ? false, fetchSubmodules ? false, owner, repo, rev, sha256
inherit owner repo rev sha256 fetchSubmodules private;
};
json = builtins.fromJSON (builtins.readFile ./github.json);
in fetch json
in fetch json
2 changes: 1 addition & 1 deletion nix/dep/tezos-baking-platform/default.nix
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# DO NOT HAND-EDIT THIS FILE
import (import ./thunk.nix)
import (import ./thunk.nix)
2 changes: 1 addition & 1 deletion nix/dep/tezos-baking-platform/thunk.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ let fetch = {url, rev, branch ? null, sha256 ? null, fetchSubmodules ? false, pr
url = realUrl; inherit rev sha256;
};
json = builtins.fromJSON (builtins.readFile ./git.json);
in fetch json
in fetch json
Loading
Loading