Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the code - Part 2 #68

Merged
merged 15 commits into from
Mar 13, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Mar 8, 2024

Follows the PR #63

@spalmer25 spalmer25 added the documentation Improvements or additions to documentation label Mar 8, 2024
@spalmer25 spalmer25 added this to the Baking app upgrade milestone Mar 8, 2024
@spalmer25 spalmer25 self-assigned this Mar 8, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch 4 times, most recently from bbf5725 to cef1706 Compare March 11, 2024 13:29
@spalmer25 spalmer25 changed the base branch from main to palmer@functori@document-the-code March 11, 2024 13:33
@spalmer25 spalmer25 marked this pull request as ready for review March 11, 2024 13:34
@spalmer25 spalmer25 linked an issue Mar 11, 2024 that may be closed by this pull request
1 task
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch from cef1706 to dc5a251 Compare March 11, 2024 14:14
Copy link
Collaborator Author

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be merged after #63

@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch from dc5a251 to 9a9aa86 Compare March 11, 2024 14:46
@spalmer25 spalmer25 linked an issue Mar 11, 2024 that may be closed by this pull request
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code branch 2 times, most recently from f6ad6c4 to 213bba6 Compare March 12, 2024 13:58
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch from 9a9aa86 to 5a61e8f Compare March 12, 2024 14:04
@spalmer25 spalmer25 changed the base branch from palmer@functori@document-the-code to main March 12, 2024 14:05
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch from 5a61e8f to 4e8e665 Compare March 13, 2024 07:51
Not every NVRAM update

 - reset: done after confirmation
 - setup: done after confirmation
 - authorize baking: done after confirmation
 - sign: done after screen-saver exit

Only deauthorize needs an explicit update
@spalmer25 spalmer25 force-pushed the palmer@functori@document-the-code-part-2 branch from 4e8e665 to 876ce55 Compare March 13, 2024 12:29
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 877b9fd into main Mar 13, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new-baking-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set warning as errors in Doxyfile Add documentation for functions and structures
2 participants