forked from LedgerHQ/app-tezos-legacy
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the code - Part 2 #68
Merged
ajinkyaraj-23
merged 15 commits into
main
from
palmer@functori@document-the-code-part-2
Mar 13, 2024
Merged
Document the code - Part 2 #68
ajinkyaraj-23
merged 15 commits into
main
from
palmer@functori@document-the-code-part-2
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
4 times, most recently
from
March 11, 2024 13:29
bbf5725
to
cef1706
Compare
spalmer25
changed the base branch from
main
to
palmer@functori@document-the-code
March 11, 2024 13:33
1 task
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
from
March 11, 2024 14:14
cef1706
to
dc5a251
Compare
spalmer25
commented
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to be merged after #63
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
from
March 11, 2024 14:46
dc5a251
to
9a9aa86
Compare
spalmer25
force-pushed
the
palmer@functori@document-the-code
branch
2 times, most recently
from
March 12, 2024 13:58
f6ad6c4
to
213bba6
Compare
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
from
March 12, 2024 14:04
9a9aa86
to
5a61e8f
Compare
spalmer25
changed the base branch from
palmer@functori@document-the-code
to
main
March 12, 2024 14:05
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
from
March 13, 2024 07:51
5a61e8f
to
4e8e665
Compare
Not every NVRAM update - reset: done after confirmation - setup: done after confirmation - authorize baking: done after confirmation - sign: done after screen-saver exit Only deauthorize needs an explicit update
…umented It enables to warn if the document is not documented and therefore fails for our CI.
spalmer25
force-pushed
the
palmer@functori@document-the-code-part-2
branch
from
March 13, 2024 12:29
4e8e665
to
876ce55
Compare
ajinkyaraj-23
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the PR #63