Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app structure compatible with app-boilerplate from Ledger #59

Merged

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Mar 1, 2024

fixes #57 , fixes #55

@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone Mar 1, 2024
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Mar 1, 2024
@ajinkyaraj-23 ajinkyaraj-23 linked an issue Mar 1, 2024 that may be closed by this pull request
4 tasks
@ajinkyaraj-23 ajinkyaraj-23 requested a review from spalmer25 March 4, 2024 13:58
@ajinkyaraj-23 ajinkyaraj-23 marked this pull request as ready for review March 4, 2024 13:58
test/apdu-tests/baking/prompt_apdus.sh Outdated Show resolved Hide resolved
.doxygen/Doxyfile Show resolved Hide resolved
.doxygen/Doxyfile Outdated Show resolved Hide resolved
.doxygen/Doxyfile Show resolved Hide resolved
.doxygen/Doxyfile Show resolved Hide resolved
.doxygen/Doxyfile Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 57-make-the-app-structure-compatible-with-app-boilerplate branch 4 times, most recently from 1974038 to 9455013 Compare March 7, 2024 11:52
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.doxygen/Doxyfile Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 57-make-the-app-structure-compatible-with-app-boilerplate branch from 9455013 to 9e9a302 Compare March 7, 2024 12:07
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 57-make-the-app-structure-compatible-with-app-boilerplate branch from 9e9a302 to f20e35e Compare March 7, 2024 12:19
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 57-make-the-app-structure-compatible-with-app-boilerplate branch from f20e35e to e22ce9d Compare March 7, 2024 13:07
@ajinkyaraj-23 ajinkyaraj-23 merged commit b6bb4c8 into main Mar 7, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the app structure compatible with app-boilerplate Update test folder regarding nix delete
2 participants