Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parser legacy code #49

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Remove parser legacy code #49

merged 6 commits into from
Feb 29, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Feb 27, 2024 •
edited
Loading

Some code was still connected to the code base, but essentially belonged to the wallet application.

  • Delete unused code.
  • Delete delegates codes as it was only useful for wallet app.
  • Delete Emmy fitness parsing.
  • Delete operations only used for wallet app.
  • Replace Athens/Babylon operations to Oxford operations

@spalmer25 spalmer25 self-assigned this Feb 27, 2024
@spalmer25
Refacto: remove unused contents
fb76bae
@spalmer25
Parser: remove old/unused operation contents
3ba004b 
 - remove athens operations
 - keep only babylon reveal and delegation operations as they are
   identical to the delegation and the reveal of Oxford and they are
   the only operations still used.
@spalmer25
Parser: remove the legacy magic byte
2d92b5d
@spalmer25
Baking parser: remove old baking parsing
6fc6a66
@spalmer25
Baking parser: remove legacy baking types
ee71c84
@spalmer25
Parser: allowing all handled operations
d58b229
@spalmer25 spalmer25 force-pushed the palmer@functori@remove-parser-legacy-code branch from 67bccb8 to d58b229 Compare February 27, 2024 13:39
@spalmer25 spalmer25 marked this pull request as ready for review February 27, 2024 13:49
ajinkyaraj-23
ajinkyaraj-23 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 9aa8aed into main Feb 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@emturner emturner Awaiting requested review from emturner

Assignees

@spalmer25 spalmer25

Labels
new-baking-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmer25 @ajinkyaraj-23