Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screensaver for nanosp/nanox and add PIN lock in screensaver/app exit #43

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Fix screensaver for nanosp/nanox and add PIN lock in screensaver/app exit #43

merged 4 commits into from
Mar 1, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 commented Feb 23, 2024 •
edited
Loading

Fixes #45 and fixes #52

@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone Feb 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this Feb 23, 2024
@spalmer25 spalmer25 linked an issue Feb 23, 2024 that may be closed by this pull request
Nano(sp/x) screensave needs to be fixed. #45
Closed
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch from 5685e99 to 1dee378 Compare February 23, 2024 16:43
spalmer25
spalmer25 reviewed Feb 26, 2024
View reviewed changes
src/ui_empty.c Outdated Show resolved Hide resolved
src/ui_empty.c Outdated Show resolved Hide resolved
src/ui_empty.c Outdated Show resolved Hide resolved
spalmer25
spalmer25 reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pin code should be required to exit the screen saver.

src/apdu_sign.c Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch 2 times, most recently from 937b59a to bcdc0b5 Compare February 27, 2024 16:46
@ajinkyaraj-23
Copy link
Collaborator Author

ajinkyaraj-23 commented Feb 27, 2024 •
edited
Loading

The pin code should be required to exit the screen saver.

Pin lock exists for app-exit. Could not add PIN to exit screensaver without obstructing the baking process.

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch 3 times, most recently from 79bc2e3 to 63527a3 Compare February 27, 2024 17:26
@ajinkyaraj-23 ajinkyaraj-23 changed the title - Fix screensaver for nanosp/nanox - Fix screensaver for nanosp/nanox and add PIN lock in screensaver/app exit. Feb 27, 2024
@ajinkyaraj-23 ajinkyaraj-23 changed the title - Fix screensaver for nanosp/nanox and add PIN lock in screensaver/app exit. Fix screensaver for nanosp/nanox and add PIN lock in screensaver/app exit Feb 27, 2024
@ajinkyaraj-23 ajinkyaraj-23 marked this pull request as ready for review February 27, 2024 17:28
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch from 63527a3 to 3195b4d Compare February 27, 2024 18:00
spalmer25
spalmer25 reviewed Feb 28, 2024
View reviewed changes
src/apdu_sign.c Outdated Show resolved Hide resolved
test/python/test_instructions.py Outdated Show resolved Hide resolved
src/ui_empty.c Outdated Show resolved Hide resolved
src/apdu_sign.c Outdated Show resolved Hide resolved
src/globals.h Outdated Show resolved Hide resolved
src/ui_empty.c Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch 5 times, most recently from 031d9f3 to 36525ce Compare February 28, 2024 23:55
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch from 36525ce to acebefb Compare February 29, 2024 15:29
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the ajinkyaraj-23@21-fix-screensaver-behavior branch from acebefb to 94b3a2e Compare February 29, 2024 21:44
spalmer25
spalmer25 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 039ae1d into main Mar 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.

Lock the ledger when baking app exits Nano(sp/x) screensave needs to be fixed.
2 participants
@ajinkyaraj-23 @spalmer25