Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing tests on the baking app #2

Merged
merged 27 commits into from
Jan 25, 2024
Merged

Focusing tests on the baking app #2

merged 27 commits into from
Jan 25, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Jan 18, 2024 •
edited
Loading

@spalmer25 spalmer25 self-assigned this Jan 18, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@add-tests-focusing-on-baking-app branch 3 times, most recently from 22ceeb3 to 3c4fc27 Compare January 19, 2024 12:32
@spalmer25 spalmer25 marked this pull request as ready for review January 19, 2024 15:10
@spalmer25 spalmer25 force-pushed the palmer@functori@add-tests-focusing-on-baking-app branch from 3c4fc27 to 99a5856 Compare January 19, 2024 15:27
@ajinkyaraj-23
Copy link
Collaborator

The target branch should be main?

@spalmer25
Tests: remove wallet app python tests
96d1982
@spalmer25
Tests: remove unused import, function, ...
8a30b7a
@spalmer25
Tests: fix typing
5d60701
@spalmer25
Tests: document function, class, file, ...
c7806a9
@spalmer25
Tests: reindent code
e6077b8
@spalmer25
Tests: rename class, function, constants, ...
89f05a0
@spalmer25
Tests: move tests in the python test root
491a2ce
@spalmer25
Tests: rename APDU parameters
eed9d40
@spalmer25
Tests: rename utils files
95b45c0
@spalmer25
Tests: define specific exchange and exchange_async client function
b70175f
@spalmer25
Tests: use process instead of exchange_async
1612169
@spalmer25
Tests: add an account module
bd5eda2
@spalmer25
Tests: use account in the client
b7a7504
@spalmer25
Tests: remove unecessary sig_scheme
a8215f2 
Set to 0xff
@spalmer25
Tests: add a pytest client parameter
5646dcd
@spalmer25
Tests: configure the default seed
db98371
@spalmer25
Tests: add tests for git and version
befe0a5
@spalmer25
Tests: add more features for account path
3480f11
@spalmer25
Tests: tests authorize feature
6b23128 
 - check public_key for authorize_baking
 - add tests for deauthorize and query_auth_key
@spalmer25
Tests: fix test_get_public_key_baking
f095c7e
@spalmer25
Tests: check public key in get_public_key tests
b46ad8d
@spalmer25 spalmer25 force-pushed the palmer@functori@add-tests-focusing-on-baking-app branch from 99a5856 to ef29c0f Compare January 23, 2024 10:28
@spalmer25 spalmer25 changed the base branch from develop to main January 23, 2024 10:28
ajinkyaraj-23
ajinkyaraj-23 reviewed Jan 23, 2024
View reviewed changes
test/python/test_instructions.py Outdated Show resolved Hide resolved
test/python/test_instructions.py Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 added this to the DAL-Support milestone Jan 23, 2024
@ajinkyaraj-23
Copy link
Collaborator

Also can you rebase on main?

@spalmer25 spalmer25 force-pushed the palmer@functori@add-tests-focusing-on-baking-app branch from ef29c0f to 8bbec9c Compare January 24, 2024 16:18
@spalmer25 spalmer25 force-pushed the palmer@functori@add-tests-focusing-on-baking-app branch from 8bbec9c to c38134b Compare January 24, 2024 16:36
ajinkyaraj-23
ajinkyaraj-23 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ajinkyaraj-23 ajinkyaraj-23 merged commit 4213636 into main Jan 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

@emturner emturner Awaiting requested review from emturner

Assignees

@spalmer25 spalmer25

Labels
new-baking-app tests
Projects
None yet
Milestone
DAL-Support
Development

Successfully merging this pull request may close these issues.
2 participants
@spalmer25 @ajinkyaraj-23