Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use magic byte instead of tag to differentiate between pre-attestation and attestation #112

Merged
merged 2 commits into from
May 30, 2024
Merged

Use magic byte instead of tag to differentiate between pre-attestation and attestation #112

merged 2 commits into from
May 30, 2024

Conversation

ajinkyaraj-23
Copy link
Collaborator

fixes #111

@ajinkyaraj-23 ajinkyaraj-23 linked an issue May 28, 2024 that may be closed by this pull request
Simplify differentiating between pre-attestation and attestation based on magic byte #111
Closed
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 111-simplify-differentiating-between-pre-attestation-and-attestation-based-on-magic-byte branch from 578eea3 to 750dd11 Compare May 28, 2024 20:10
@ajinkyaraj-23 ajinkyaraj-23 requested a review from spalmer25 May 28, 2024 20:11
@ajinkyaraj-23 ajinkyaraj-23 self-assigned this May 28, 2024
@ajinkyaraj-23 ajinkyaraj-23 added this to the Baking app upgrade milestone May 28, 2024
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 111-simplify-differentiating-between-pre-attestation-and-attestation-based-on-magic-byte branch from 750dd11 to 25aa20b Compare May 28, 2024 20:14
spalmer25
spalmer25 reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@spalmer25 spalmer25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why we have to do this changes.
Does checking the attestation/pre-attestation tag leads to some issues ?

src/baking_auth.c Outdated Show resolved Hide resolved
@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 111-simplify-differentiating-between-pre-attestation-and-attestation-based-on-magic-byte branch from 25aa20b to a9325cf Compare May 29, 2024 09:43
@ajinkyaraj-23
Copy link
Collaborator Author

Its a minor optimization. It came up in discussion in Proto-ecosystem team where they mentioned that tag is not necessary for signers.

@ajinkyaraj-23 ajinkyaraj-23 force-pushed the 111-simplify-differentiating-between-pre-attestation-and-attestation-based-on-magic-byte branch from ae8ac0f to 10a7046 Compare May 29, 2024 21:19
@ajinkyaraj-23 ajinkyaraj-23 merged commit 8813b20 into main May 30, 2024
29 checks passed
ajinkyaraj-23 added a commit that referenced this pull request Jun 4, 2024
@ajinkyaraj-23
Merge pull request #112 from trilitech/111-simplify-differentiating-b…
3a4b518 
…etween-pre-attestation-and-attestation-based-on-magic-byte

Use magic byte instead of tag to differentiate between pre-attestation and attestation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmer25 spalmer25 spalmer25 approved these changes

Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
new-baking-app
Projects
None yet
Milestone
Baking app upgrade
Development

Successfully merging this pull request may close these issues.

Simplify differentiating between pre-attestation and attestation based on magic byte
2 participants
@ajinkyaraj-23 @spalmer25