amesos2(KLU2): enhance standalone testing #12232

romintomasetti · 2023-09-08T13:16:26Z

@trilinos/amesos2

Motivation

As mentioned in #12209 and #12219, @maartenarnst and myself are tracking a bug in KLU2 that only happens for gcc-12 (and also gcc-13...) in Release mode (basically -O3).

The problem was that the function KLU_lsolve (in packages/amesos2/src/KLU2/Source/klu2.hpp) was simply optimized away by the compiler in that specific configuration, though it has clear side effects/observable effects when called from KLU_solve2 in packages/amesos2/src/KLU2/Source/klu2_solve.hpp.

Adding something like the following asm(""), or adding a printf anywhere in KLU_lsolve would prevent the compiler from optimizing it away. So the first fix was something like this:

 #if defined(__GNUC__) && __GNUC__ >= 12
     asm("");
 #endif

However, we judged that fix ugly enough that we looked for something nicer and came up with adding a default to the switch:

default:
            throw std::domain_error("More than 4 right-hand sides is not supported.");

and that would also prevent gcc-12 removing KLU_lsolve.

We really think it is a compiler bug. It also happens with gcc-13. Should we report a bug to them? Note that we were not able to come up with a minimal reproducer.

romintomasetti · 2023-09-08T13:17:21Z

packages/amesos2/src/KLU2/Source/CMakeLists.txt

 #

-TRIBITS_ADD_EXAMPLE_DIRECTORIES(examples)
+TRIBITS_ADD_TEST_DIRECTORIES(tests)


Note for the reviewer(s): I promoted the example to being a "standalone test" of the KLU2 sources.

romintomasetti · 2023-09-08T13:18:18Z

packages/amesos2/src/KLU2/Source/tests/klu2_simple.cpp

@@ -0,0 +1,183 @@
+// @HEADER


Also note for the reviewer(s): I used git mv bug there are too many changes so git considers it deleted and re-created.

trilinos-autotester · 2023-09-08T13:26:52Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

romintomasetti · 2023-09-08T13:31:10Z

packages/amesos2/src/KLU2/Include/klu2_internal.h

@@ -198,67 +198,6 @@ size_t KLU_kernel_factor            /* 0 if failure, size of LU if OK */
    KLU_common<Entry, Int> *Common  /* the control input/output structure */
 ) ;

-template <typename Entry, typename Int>


Note for the reviewer(s): Here I deleted the forward declarations because there is no ETI for these. I guess in the very first version it was here a header file, and klu2.hpp was actually a .cpp file. And then it was changed to become templated.

sebrowne · 2023-09-12T18:13:54Z

I recommend rebasing this branch given the 'develop' history change.

trilinos-autotester · 2023-09-13T06:20:07Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

srajama1

Thanks @romintomasetti and @maartenarnst !

trilinos-autotester · 2023-09-14T22:32:16Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-09-14T22:34:05Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2867
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1366
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1356
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1355
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2570
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2358
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 997
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

trilinos-autotester · 2023-09-15T00:42:42Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2867
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1366
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1356
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1355
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2570
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2358
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 997
Status: FAILED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`9254c4d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

CDash Test Results for PR# 12232.

Wiki: How to Reproduce PR Testing Builds and Errors.

maartenarnst · 2023-09-19T16:11:39Z

Hi @srajama1. It seems some of the tests failed for this one. On our side, @romintomasetti and I don't have permissions to look into the CDash or ask for a retest. Would you have a moment to do one of those things to move this forward? Thanks.

iyamazaki · 2023-09-20T22:40:21Z

@maartenarnst Thank you for the PR, and I am sorry for missing it. The errors seem to happen when building the simple test with the complex scalar type, and I could reproduce them locally, e.g.,

Trilinos/packages/amesos2/src/KLU2/Source/klu2_scale.hpp(166): error: no suitable conversion function from "std::complex<double>" to "double" exists
              KLU2_ABS (a, Az [p]) ;
          detected during:
            instantiation of "Int klu_scale(Int, Int, Int *, Int *, Entry *, double *, Int *, klu_common<Entry, Int> *) [with Entry=std::complex<double>, Int=int]" at line 151 of "Trilinos/packages/amesos2/src/KLU2/Source/klu2_factor.hpp"
            instantiation of "void factor2(Int *, Int *, Entry *, klu_symbolic<Entry, Int> *, klu_numeric<Entry, Int> *, klu_common<Entry, Int> *) [with Entry=std::complex<double>, Int=int]" at line 562 of "Trilinos/packages/amesos2/src/KLU2/Source/klu2_factor.hpp"
            instantiation of "klu_numeric<Entry, Int> *klu_factor(Int *, Int *, Entry *, klu_symbolic<Entry, Int> *, klu_common<Entry, Int> *) [with Entry=std::complex<double>, Int=int]" at line 147 of "Trilinos/packages/amesos2/src/KLU2/Source/tests/klu2_simple.cpp"
            instantiation of "void solve_and_check<T,D,tol_t>(tol_t) [with T=std::complex<double>, D=int, tol_t=double]" at line 180 of "Trilinos/packages/amesos2/src/KLU2/Source/tests/klu2_simple.cpp"

maartenarnst · 2023-09-20T23:30:38Z

Hi @iyamazaki. Thanks for looking into it and letting us know about the error. It seems we weren't protecting the test for the case of the complex scalar type with the HAVE_TEUCHOS_COMPLEX macro. I've added it. Would you have a moment to set it up for a retest? Thanks in advance!

trilinos-autotester · 2023-09-21T09:22:34Z

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

trilinos-autotester · 2023-09-21T09:22:41Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2023-09-21T09:24:31Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2922
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1421
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1411
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1410
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2625
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2413
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1052
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Using Repos:

Repo: TRILINOS (uliegecsm/Trilinos)

Pull Request Author: romintomasetti

trilinos-autotester · 2023-09-21T11:48:53Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2922
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1421
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1411
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1410
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2625
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2413
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 1052
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS	AT: RETEST
PULLREQUESTNUM	12232
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_REPO	https://github.com/uliegecsm/Trilinos
TRILINOS_SOURCE_SHA	`ea5c7b5`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ff92fc9`

CDash Test Results for PR# 12232.

trilinos-autotester · 2023-09-21T11:49:11Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!

trilinos-autotester · 2023-09-21T11:49:18Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

iyamazaki · 2023-09-21T19:03:56Z

Thank you for the change @maartenarnst! I just want to double-check with @ndellingwood. I feel a bit strange that we have to protect Amesos2 tester with HAVE_TEUCHOS_COMPLEX?

maartenarnst · 2023-09-21T20:41:10Z

Hi @iyamazaki.

OK of course to check with @ndellingwood.

Just a few thoughts to try to help the discussion:

The use of HAVE_TEUCHOS_COMPLEX is not new. It was already in the file KLU2/Source/Examples/klu2_simple.cpp that this PR turns into a test. In this file in the current develop branch:

Trilinos/packages/amesos2/src/KLU2/Source/examples/klu2_simple.cpp

Lines 92 to 109 in 95b7942

    
           #ifdef HAVE_TEUCHOS_COMPLEX 
        
               std::cout << "Complex double case " << std::endl ; 
        
               typedef std::complex<double> ComplexD ; 
        
               klu_symbolic<ComplexD, int> *Symbolic_C ; 
        
               klu_numeric<ComplexD, int> *Numeric_C ; 
        
               klu_common<ComplexD, int> Common_C ; 
        
               klu_defaults<ComplexD, int> (&Common_C) ; 
        
               Symbolic_C = klu_analyze<ComplexD, int> (n, Ap, Ai, &Common_C) ; 
        
               Numeric_C = klu_factor<ComplexD, int> (Ap, Ai, Ax_cd, Symbolic_C, &Common_C) ; 
        
               klu_solve<ComplexD, int> (Symbolic_C, Numeric_C, 5, 1, b_cd, &Common_C) ; 
        
               for (i = 0 ; i < n ; i++)  
        
                   std::cout << "Non-transpose: x [" << i << "] = "<< b_cd[i] << std::endl ; 
        
               klu_tsolve<ComplexD, int> (Symbolic_C, Numeric_C, 5, 1, b_cd, &Common_C) ; 
        
               for (i = 0 ; i < n ; i++)  
        
                   std::cout << "Transpose: x [" << i << "] = "<< b_cd[i] << std::endl ; 
        
               klu_free_symbolic<ComplexD, int> (&Symbolic_C, &Common_C) ; 
        
               klu_free_numeric<ComplexD, int> (&Numeric_C, &Common_C) ; 
        
           #endif

If we don't use HAVE_TEUCHOS_COMPLEX to protect the test, we run into the test failures that we had seen. The reason seems to be that there are places in the main KLU2 code where HAVE_TEUCHOS_COMPLEX is used. It seems that if we remove this protection at one location, such as the example/test, we'll have to be consistent and remove it systematically.

Trilinos/packages/amesos2/src/KLU2/Include/klu2_scalartraits.h

Lines 91 to 95 in 95b7942

    
           #ifdef HAVE_TEUCHOS_COMPLEX 
        
           template <typename T> 
        
           struct KLU_ScalarTraits< 
        
           std::complex<T>

@romintomasetti authored this PR. When he and I talked this morning, he too expressed that he felt that it is strange to use the HAVE_TEUCHOS_COMPLEX in the test. I agree with both of you. It's just that if we change it, there may be quite a few other things that we'll have to change.

ndellingwood

Thanks for the contributions!
Yeah, adding the HAVE_TEUCHOS_COMPLEX to guard the test seems the easiest way to handle the existing guarding mentioned by @maartenarnst at e.g. Trilinos/packages/amesos2/src/KLU2/Include/klu2_scalartraits.h

Adding the pre-test-inspection and automerge label so we can get this in, thanks again

trilinos-autotester · 2023-09-22T03:23:16Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ndellingwood ]!

trilinos-autotester · 2023-09-22T03:23:23Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2023-09-22T03:23:36Z

Merge on Pull Request# 12232: IS A SUCCESS - Pull Request successfully merged

romintomasetti commented Sep 8, 2023

View reviewed changes

romintomasetti force-pushed the amesos2-gcc-12-fix-klu2 branch from 9035932 to 80441c8 Compare September 8, 2023 13:29

romintomasetti commented Sep 8, 2023

View reviewed changes

sebrowne force-pushed the develop branch from cb70492 to ff92fc9 Compare September 12, 2023 16:52

amesos2(KLU2): enhance standalone testing

9254c4d

maartenarnst force-pushed the amesos2-gcc-12-fix-klu2 branch from 80441c8 to 9254c4d Compare September 12, 2023 18:30

srajama1 previously approved these changes Sep 14, 2023

View reviewed changes

srajama1 added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 14, 2023

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 14, 2023

Protect call for complex scalar type with HAVE_TEUCHOS_COMPLEX

ea5c7b5

maartenarnst dismissed srajama1’s stale review via ea5c7b5 September 20, 2023 23:26

iyamazaki added AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Sep 20, 2023

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Sep 21, 2023

trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Sep 21, 2023

ndellingwood approved these changes Sep 22, 2023

View reviewed changes

ndellingwood added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels Sep 22, 2023

trilinos-autotester merged commit f1282ab into trilinos:develop Sep 22, 2023
2 checks passed

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 22, 2023

amesos2(KLU2): enhance standalone testing #12232

amesos2(KLU2): enhance standalone testing #12232

Conversation

romintomasetti commented Sep 8, 2023 • edited Loading

Motivation

romintomasetti Sep 8, 2023

Choose a reason for hiding this comment

romintomasetti Sep 8, 2023

Choose a reason for hiding this comment

trilinos-autotester commented Sep 8, 2023

romintomasetti Sep 8, 2023

Choose a reason for hiding this comment

sebrowne commented Sep 12, 2023

trilinos-autotester commented Sep 13, 2023

srajama1 left a comment

Choose a reason for hiding this comment

trilinos-autotester commented Sep 14, 2023

trilinos-autotester commented Sep 14, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Sep 15, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

maartenarnst commented Sep 19, 2023

iyamazaki commented Sep 20, 2023

maartenarnst commented Sep 20, 2023

trilinos-autotester commented Sep 21, 2023

trilinos-autotester commented Sep 21, 2023

trilinos-autotester commented Sep 21, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

romintomasetti commented Sep 8, 2023 •

edited

Loading