Propshaft #89

tricknotes · 2024-08-21T16:02:53Z

Migrate SCSS to CSS.
Drop sprockets.
Drop Node.js and its dependencies.

tricknotes · 2024-08-22T15:53:35Z

Umm, Gmail doesn't support custom css property.
https://developers.google.com/gmail/design/css#supported_css

Now, we use no any Node.js based compilers.

To support Gmail.

tricknotes · 2024-08-22T16:09:08Z

Okay, almost works.

tricknotes · 2024-08-23T03:12:04Z

This PR reduced slug size.

--- before.txt	2024-08-23 12:09:52
+++ after.txt	2024-08-23 12:10:40
@@ -7,47 +7,32 @@
 -----> Using Ruby version: ruby-3.3.4
 -----> Installing dependencies using bundler 2.5.6
        Running: BUNDLE_WITHOUT='development:test' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
-       Bundle complete! 22 Gemfile dependencies, 99 gems now installed.
+       Bundle complete! 20 Gemfile dependencies, 93 gems now installed.
        Gems in the groups 'development' and 'test' were not installed.
        Bundled gems are installed into `./vendor/bundle`
-       Bundle completed (0.44s)
+       Bundle completed (0.46s)
        Cleaning up the bundler cache.
        Removing bundler (2.5.6)
-###### WARNING:
-       Installing a default version (20.9.0) of Node.js.
-       This version is not pinned and can change over time, causing unexpected failures.
-       
-       Heroku recommends placing the `heroku/nodejs` buildpack in front of
-       `heroku/ruby` to install a specific version of node:
-       
-       https://devcenter.heroku.com/articles/ruby-support#node-js-support
------> Installing node-v20.9.0-linux-x64
 -----> Detecting rake tasks
 -----> Preparing app for Rails asset pipeline
        Running: rake assets:precompile
        To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
        To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
-       Asset precompilation completed (2.66s)
+       I, [2024-08-22T16:01:45.734498 #284]  INFO -- : Writing application-3f50a875.css
+       Asset precompilation completed (2.34s)
        Cleaning assets
        Running: rake assets:clean
        To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
        To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
+       I, [2024-08-22T16:01:48.010420 #289]  INFO -- : Removed application-1a927a8398e21c238ff3e05c201713897dee33e29f5689349aa9f3157a7c309e.css
 -----> Detecting rails configuration
-###### WARNING:
-       Installing a default version (20.9.0) of Node.js.
-       This version is not pinned and can change over time, causing unexpected failures.
-       
-       Heroku recommends placing the `heroku/nodejs` buildpack in front of
-       `heroku/ruby` to install a specific version of node:
-       
-       https://devcenter.heroku.com/articles/ruby-support#node-js-support
 -----> Discovering process types
        Procfile declares types     -> web
        Default types for buildpack -> console, rake
 -----> Compressing...
-       Done: 77.4M
+       Done: 40.1M
 -----> Launching...
-       Released v673
+       Released v678
        https://starseeker-dev.herokuapp.com/ deployed to Heroku
 This app is using the Heroku-22 stack, however a newer stack is available.
 To upgrade to Heroku-24, see:

Before

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/ruby
-----> Ruby app detected
-----> Installing bundler 2.5.6
-----> Removing BUNDLED WITH version in the Gemfile.lock
-----> Compiling Ruby/Rails
-----> Using Ruby version: ruby-3.3.4
-----> Installing dependencies using bundler 2.5.6
       Running: BUNDLE_WITHOUT='development:test' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       Bundle complete! 22 Gemfile dependencies, 99 gems now installed.
       Gems in the groups 'development' and 'test' were not installed.
       Bundled gems are installed into `./vendor/bundle`
       Bundle completed (0.44s)
       Cleaning up the bundler cache.
       Removing bundler (2.5.6)
###### WARNING:
       Installing a default version (20.9.0) of Node.js.
       This version is not pinned and can change over time, causing unexpected failures.
       
       Heroku recommends placing the `heroku/nodejs` buildpack in front of
       `heroku/ruby` to install a specific version of node:
       
       https://devcenter.heroku.com/articles/ruby-support#node-js-support
-----> Installing node-v20.9.0-linux-x64
-----> Detecting rake tasks
-----> Preparing app for Rails asset pipeline
       Running: rake assets:precompile
       To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
       To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
       Asset precompilation completed (2.66s)
       Cleaning assets
       Running: rake assets:clean
       To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
       To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
-----> Detecting rails configuration
###### WARNING:
       Installing a default version (20.9.0) of Node.js.
       This version is not pinned and can change over time, causing unexpected failures.
       
       Heroku recommends placing the `heroku/nodejs` buildpack in front of
       `heroku/ruby` to install a specific version of node:
       
       https://devcenter.heroku.com/articles/ruby-support#node-js-support
-----> Discovering process types
       Procfile declares types     -> web
       Default types for buildpack -> console, rake
-----> Compressing...
       Done: 77.4M
-----> Launching...
       Released v673
       https://starseeker-dev.herokuapp.com/ deployed to Heroku
This app is using the Heroku-22 stack, however a newer stack is available.
To upgrade to Heroku-24, see:
https://devcenter.heroku.com/articles/upgrading-to-the-latest-stack

After

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/ruby
-----> Ruby app detected
-----> Installing bundler 2.5.6
-----> Removing BUNDLED WITH version in the Gemfile.lock
-----> Compiling Ruby/Rails
-----> Using Ruby version: ruby-3.3.4
-----> Installing dependencies using bundler 2.5.6
       Running: BUNDLE_WITHOUT='development:test' BUNDLE_PATH=vendor/bundle BUNDLE_BIN=vendor/bundle/bin BUNDLE_DEPLOYMENT=1 bundle install -j4
       Bundle complete! 20 Gemfile dependencies, 93 gems now installed.
       Gems in the groups 'development' and 'test' were not installed.
       Bundled gems are installed into `./vendor/bundle`
       Bundle completed (0.46s)
       Cleaning up the bundler cache.
       Removing bundler (2.5.6)
-----> Detecting rake tasks
-----> Preparing app for Rails asset pipeline
       Running: rake assets:precompile
       To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
       To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
       I, [2024-08-22T16:01:45.734498 #284]  INFO -- : Writing application-3f50a875.css
       Asset precompilation completed (2.34s)
       Cleaning assets
       Running: rake assets:clean
       To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
       To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
       I, [2024-08-22T16:01:48.010420 #289]  INFO -- : Removed application-1a927a8398e21c238ff3e05c201713897dee33e29f5689349aa9f3157a7c309e.css
-----> Detecting rails configuration
-----> Discovering process types
       Procfile declares types     -> web
       Default types for buildpack -> console, rake
-----> Compressing...
       Done: 40.1M
-----> Launching...
       Released v678
       https://starseeker-dev.herokuapp.com/ deployed to Heroku
This app is using the Heroku-22 stack, however a newer stack is available.
To upgrade to Heroku-24, see:
https://devcenter.heroku.com/articles/upgrading-to-the-latest-stack

tricknotes force-pushed the propshaft branch 2 times, most recently from 30f6dcc to 3f9f561 Compare August 21, 2024 16:13

tricknotes temporarily deployed to starseeker-dev August 21, 2024 16:18 Inactive

tricknotes temporarily deployed to starseeker-dev August 22, 2024 01:44 Inactive

tricknotes force-pushed the propshaft branch 2 times, most recently from 5c503c7 to 3f9f561 Compare August 22, 2024 13:25

tricknotes temporarily deployed to starseeker-dev August 22, 2024 15:27 Inactive

tricknotes temporarily deployed to starseeker-dev August 22, 2024 16:01 Inactive

tricknotes added 13 commits August 23, 2024 01:08

Remove unnecessary vendor prefix

a1ee295

Use global custom attribute

2d6a6ff

Expand scss function: divide-equally

c09d08a

Expand nested scss

b871e53

Extract transitions

b1e811d

Expand function: shadow

caf264d

Change scss to css

432b891

Remove usage of sprockets based helper methods

857d1da

Replace sprockets with propshaft

90f0e88

Drop uglifier

1dae65b

Drop Node.js

7c1ce67

Now, we use no any Node.js based compilers.

Fix css to use :root for custom properties

ecfc0ae

Set default value to --link-color

01ae0da

To support Gmail.

tricknotes force-pushed the propshaft branch from 8893e96 to 01ae0da Compare August 22, 2024 16:08

tricknotes merged commit d2f974f into main Aug 22, 2024
3 checks passed

tricknotes deleted the propshaft branch August 22, 2024 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propshaft #89

Propshaft #89

tricknotes commented Aug 21, 2024 •

edited

Loading

tricknotes commented Aug 22, 2024

tricknotes commented Aug 22, 2024

tricknotes commented Aug 23, 2024 •

edited

Loading

Propshaft #89

Propshaft #89

Conversation

tricknotes commented Aug 21, 2024 • edited Loading

tricknotes commented Aug 22, 2024

tricknotes commented Aug 22, 2024

tricknotes commented Aug 23, 2024 • edited Loading

tricknotes commented Aug 21, 2024 •

edited

Loading

tricknotes commented Aug 23, 2024 •

edited

Loading