Improve random int #14828
Closed
Improve random int #14828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
requested review from
karliatto,
marekrjpolak and
szymonlesisz
as code owners
peter-sanderson
force-pushed
the
improve-random-int
branch
from
ee18606
to
734e974
Compare
peter-sanderson
requested review from
komret,
mroz22 and
martykan
as code owners
peter-sanderson
commented
Oct 14, 2024
| @@ -44,7 +44,7 @@ const config: webpack.Configuration = { | |||
| src: path.resolve(__dirname, '../../suite/src/'), | |||
| }, | |||
| fallback: { | |||
| // Polyfills crypto API for NodeJS libraries in the browser. 'crypto' does not run without 'stream' | |||
| // Polyfills crypto API for Node.js libraries in the browser. 'crypto' does not run without 'stream' | |||
There was a problem hiding this comment.
I received a notice, that this is the official™ spelling is Node.js. 🤷
peter-sanderson
force-pushed
the
improve-random-int
branch
3 times, most recently
from
db025fb
to
61d28fc
Compare
peter-sanderson
force-pushed
the
improve-random-int
branch
2 times, most recently
from
13b1c56
to
299bc68
Compare
peter-sanderson
commented
Oct 15, 2024
| @@ -14,7 +14,7 @@ | |||
| "test:e2e:new-bridge:hw": "USE_HW=true USE_NODE_BRIDGE=true yarn test:e2e:bridge", | |||
| "test:e2e:new-bridge:emu": "USE_HW=false USE_NODE_BRIDGE=true yarn test:e2e:bridge", | |||
| "build:e2e:api:node": "yarn esbuild ./e2e/api/api.test.ts --bundle --outfile=./e2e/dist/api.test.node.js --platform=node --target=node18 --external:usb", | |||
| "build:e2e:api:browser": "yarn esbuild ./e2e/api/api.test.ts --bundle --outfile=./e2e/dist/api.test.browser.js --platform=browser --external:usb && cp e2e/ui/api.test.html e2e/dist/index.html", | |||
| "build:e2e:api:browser": "yarn esbuild ./e2e/api/api.test.ts --bundle --alias:crypto=crypto-browserify --alias:stream=stream-browserify --outfile=./e2e/dist/api.test.browser.js --platform=browser --external:usb && cp e2e/ui/api.test.html e2e/dist/index.html", | |||
There was a problem hiding this comment.
Took me a while to figure this out: https://esbuild.github.io/api/#alias
peter-sanderson
force-pushed
the
improve-random-int
branch
from
299bc68
to
3ba7748
Compare
peter-sanderson
force-pushed
the
improve-random-int
branch
from
3ba7748
to
42529a9
Compare
mroz22
reviewed
Oct 15, 2024
| @@ -45,7 +45,8 @@ | |||
| "dependencies": { | |||
| "@trezor/connect": "workspace:*", | |||
| "@trezor/connect-common": "workspace:*", | |||
| "@trezor/utils": "workspace:*" | |||
| "@trezor/utils": "workspace:*", | |||
| "crypto-browserify": "^3.12.0" | |||
There was a problem hiding this comment.
dependency or devDependency ? 🤔
There was a problem hiding this comment.
It depends... 🤣
There was a problem hiding this comment.
it should, imho, be only devDependency. because we only need it to produce lib using build:lib. it shouldn't be needed in the runtime of this package at all I believe.
There was a problem hiding this comment.
connect-web itself only imports scheduleAction, createDeferred and createDeferredManager
mroz22
reviewed
Oct 15, 2024
| @@ -25,6 +25,7 @@ | |||
| "@trezor/device-utils": "workspace:*", | |||
| "@trezor/transport": "workspace:*", | |||
| "@trezor/urls": "workspace:*", | |||
| "crypto-browserify": "^3.12.0", | |||
There was a problem hiding this comment.
and what about stream-browserify. this is transient?
There was a problem hiding this comment.
yes, I used the same approach as was in suite package
|
=> #14878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRandomNumberInRangetogetWeakRandomNumberInRangerandomIntthat usescryptolib (becauserandomIntfrom crypto is not supported bycrypto-browserify=> feat: crypto.randomInt([min, ]max[, callback]) browserify/crypto-browserify#224)arrayShufflenow usesrandomIntand thereforecryptolib