Support serializing bigint values #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The available JSON serialization utilities do not natively support `stringify`ing `BigInt` values, but they do support passing replacer arguments for serialization of custom or unsupported types. In order not to crash when serializing BigInt values, we can pass a replacer function that substitutes these values to a string representation. The chosen format is `12345n`, which aligns with most other string representations, as well as the shorthand syntax in later versions of JavaScript.
|
@trentm sorry to pester you on this. Any interest in getting this quick fix merged? I understand if not, but would be helpful to know if I should spend any more time on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #662
The available JSON serialization utilities do not natively support
stringifyingBigIntvalues, but they do support passing replacer arguments for serialization of custom or unsupported types.In order not to crash when serializing BigInt values, we can pass a replacer function that substitutes these values to a string representation. The chosen format is
12345n, which aligns with most other string representations, as well as the shorthand syntax in later versions of JavaScript.