filesize logrotate and log only specified level option #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2016 19:04
#1) * add support for rotating by file size and for logging only set level (global setting) * update README, coding style, fix rotate size
noamknispel
reviewed
Oct 22, 2016
| @@ -333,6 +333,8 @@ function isWritable(obj) { | |||
| * See README.md for full details. | |||
| * - `level`: set the level for a single output stream (cannot be used | |||
| * with `streams`) | |||
| * - `logOnlySetLevel`: Use level as the only level to log and not a | |||
| * threshold (Defaut: false) | |||
|
I've been hoping for file size based rotation for a while, hope this gets merged |
brunogsa
reviewed
Nov 2, 2016
| @@ -892,7 +892,8 @@ var log = bunyan.createLogger({ | |||
| type: 'rotating-file', | |||
| path: '/var/log/foo.log', | |||
| period: '1d', // daily rotation | |||
| count: 3 // keep 3 back copies | |||
| count: 3, // keep 3 back copies, | |||
| maxSizeKB: 1024 // rotate every 1024KB | |||
There was a problem hiding this comment.
I think you should add a proper explanation of what the "maxSizeKB" attribute does.
If you expand the code below, you'll see:
"Currently, there is no support for providing a template for the rotated files, or for rotating when the log reaches a threshold size."
Which is no longer true.
| @@ -333,6 +333,8 @@ function isWritable(obj) { | |||
| * See README.md for full details. | |||
| * - `level`: set the level for a single output stream (cannot be used | |||
| * with `streams`) | |||
| * - `logOnlySetLevel`: Use level as the only level to log and not a | |||
There was a problem hiding this comment.
You didn't use any attribute "logOnlySetLevel".
Should it be "logOnlyMinLevel"?
| @@ -892,7 +892,8 @@ var log = bunyan.createLogger({ | |||
| type: 'rotating-file', | |||
| path: '/var/log/foo.log', | |||
| period: '1d', // daily rotation | |||
| count: 3 // keep 3 back copies | |||
| count: 3, // keep 3 back copies, | |||
| maxSizeKB: 1024 // rotate every 1024KB | |||
There was a problem hiding this comment.
You might also consider adding some instructions explaining how and where to set "logOnlyMinLevel" parameter.
I'm sorry if it's obvious and I didn't get it. :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for log rotation with file size limitation additionally to the period of time rotation.
Also, add support to log only the specific log level (e.g: log only WARN), this is a global setting that will affect all streams.
Will create a patch in the future to add per stream support if will be required.