Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: On reopenFileStream reopen children's streams as well #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steppicrew
Copy link

We had a problem in restify's audit logger. It creates a child of the given logger and there was no way to reopen all file streams for log rotation.
So we register forked instances at the parent to reopen their streams as well.

@UnitedMarsupials-zz
Copy link

I had the same problem -- reported in #563. But is this the right fix? Shouldn't the children point at the same (parent's) streams array to begin with -- instead of holding copies and thus need to reopen them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants