Add rotation of log files by size. Configuration requires user to pr… #288
Conversation
…vide only rotation by period or size - configuration by both is not allowed. Because of the buffering done by streams, the rotation will be approximate. This is especially true if log messages are coming in at a very high rate.
…pon initialization if it is already above the configured size threshold.
…le size, continue to truncate to the file.
|
+1 |
|
+1 👍 |
trentm
added
needslabels
needstriage
Type-Improvement
Component-LibRotation
and removed
needslabels
labels
| @@ -1339,7 +1380,13 @@ RotatingFileStream.prototype.write = function write(s) { | |||
| this.rotQueue.push(s); | |||
| return false; | |||
| } else { | |||
| return this.stream.write(s); | |||
| if ((this.alreadyWritten + this.stream.bytesWritten) > this.rotateFileSize) { | |||
There was a problem hiding this comment.
By checking the file and rotating immediately, we lose the log message that caused the rotation.
Can be resolved by adding a "this.rotQueue.push(s);" before the call to rotate.
Although the function returns false, this isn't an indicator that the caller should retry - simply an indicator that the data has been buffered.
There was a problem hiding this comment.
Thanks for catching this! Fixed!
On Sat, Feb 6, 2016 at 10:55 AM, Jim Tupper [email protected]
wrote:
In lib/bunyan.js
#288 (comment):@@ -1339,7 +1380,13 @@ RotatingFileStream.prototype.write = function write(s) {
this.rotQueue.push(s);
return false;
} else {
return this.stream.write(s);if ((this.alreadyWritten + this.stream.bytesWritten) > this.rotateFileSize) {By checking the file and rotating immediately, we lose the log message
that caused the rotation—
Reply to this email directly or view it on GitHub
https://github.com/trentm/node-bunyan/pull/288/files#r52103575.
Kevin Smathers
Product Development Engineer
Tanium, Inc.
[email protected]
|
+1 |
Re-enable close function
|
Do you plan to merge the PR? |
…ovide only rotation by period or size - configuration by both is not allowed. Because of the buffering done by streams, the rotation will be approximate. This is especially true if log messages are coming in at a very high rate.