Standard err serializer: better support for caused errors #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made some tiny changes that make the default `err` serializer support a wider range of caused errors, namely also those that have a `cause` property. I have also changed a little bit the connecting message in the full error stack to integrate better with the default stack trace formatter. Thank you.
| cex = ex.cause(); | ||
| } | ||
| if (typeof (ex.cause) === 'object') { | ||
| cex = ex.cause; |
There was a problem hiding this comment.
No problem, it could even be a switch statement.
|
Thanks for the PR! And sorry for the delay in responding. I have a couple small Qs above. |
trentm
added
needslabels
needstriage
Type-Improvement
Component-Lib
and removed
needslabels
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some tiny changes that make the default
errserializer support a wider range of caused errors, namely also those that have acauseproperty. I have also changed a little bit the connecting message in the full error stack to integrate better with the default stack trace formatter.Thank you.