Extract the formatter from the command line tool #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2014 13:40
…fy a custom formatter, add tests for command line arguments
trentm
added
needslabels
needstriage
Type-Improvement
Component-CLI
and removed
needslabels
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in the process of switching my logging from winston to bunyan. Since the screen output is now done this way, there's no easy way to modify the screen output if you don't want one of the options bunyan comes with; the command line tool is hardcoded to output to stdout. It has lots of useful functionality though, so it would be useful to keep all that functionality and just be able to format your content with a separate module.
I've done this here. Merge if you like.