Added stackTraceLimit to the options of Logger #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
added
needslabels
needstriage
Type-Improvement
Component-Lib
and removed
needslabels
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Kibana, Logstash and Elastic search to pull the logs onto a server to analyize and needed a way to verify a certain schema in the info object passed to mkLogEmitter. While doing this, the stacktrace was actually 2 levels deeper than what getCaller3Info was looking for. Added stackTraceLimit to the options in Logger and passing that number to getCaller3Info fixed our problem.